pwm: add sysfs interface
Hi Oliver!
As you are not the first one asking for the status of the pwm sysfs interface I post my answer to the linux-kernel list in hope others will benefit.
Quoted 9 lines · Oliver Schinagl
Hi lars,
I have trouble seeing if your patch has been applied yet to the kernel tree. I do see it in patchwork.
https://patchwork.kernel.org/patch/2163151/But don't see sysfs features in
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/pwm/core.c
It is not merged and will never be.
Quoted 2 lines
If you haven't had time to take Greg's comments into account, would there be a possibility for you to correct those and re-submit?
I already did resubmit an updated version taking Greg's comments into account. You can find the thread here:
http://marc.info/?l=linux-kernel&m=136499756101273&w=2
https://patchwork.kernel.org/patch/2387391/
Also this version will not get merged into mainline. I have to do a v2 according to Thierry's comments. I have planed to do it, but I will not find the time during the next say 2 months.
Quoted 2 lines
If not, I'd be happy to pull your patch, fix and re-submit (giving you full credit of course).
You're welcome! This is a community project. And there is nothing special to pull or something. Just take the patch from patchwork and work on it.
Quoted 2 lines
Your sysfs driver feature is quite awesome and makes using PWM's quite cool, so that's definitely a good feature to have in the kernel.
Thanks!
Thank you for your interest!
Regards,
Lars
Quoted 25 lines · Lars Poeschel
Hi Oliver!
As you are not the first one asking for the status of the pwm sysfs interface I post my answer to the linux-kernel list in hope others will benefit.
Quoted 9 lines · Oliver Schinagl
Hi lars,
I have trouble seeing if your patch has been applied yet to the kernel tree. I do see it in patchwork.
https://patchwork.kernel.org/patch/2163151/But don't see sysfs features in
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/pwm/core.cIt is not merged and will never be.
Quoted 2 lines
If you haven't had time to take Greg's comments into account, would there be a possibility for you to correct those and re-submit?
I already did resubmit an updated version taking Greg's comments into account. You can find the thread here:
Quoted 6 lines
http://marc.info/?l=linux-kernel&m=136499756101273&w=2
https://patchwork.kernel.org/patch/2387391/Also this version will not get merged into mainline. I have to do a v2 according to Thierry's comments. I have planed to do it, but I will not find the time during the next say 2 months.
Ok, keep me updated. If in the meantime I find time, I'll take the next set of comments into account and re-submit it, with a CC to you. If you hear nothing, don't let that hold you back ;)
Quoted 16 lines
Quoted 3 lines
If not, I'd be happy to pull your patch, fix and re-submit (giving you full credit of course).
You're welcome! This is a community project. And there is nothing special to pull or something. Just take the patch from patchwork and work on it.
Quoted 2 lines
Your sysfs driver feature is quite awesome and makes using PWM's quite cool, so that's definitely a good feature to have in the kernel.
Thanks!
Thank you for your interest!Regards,
Lars