arch: mips: kernel: using strlcpy() instead of strncpy()
Subsystems (2)
PATCH 1/1 arch: mips: kernel: using strlcpy() instead of strncpy()
For NUL terminated string, need always be sure of ended by zero.
Or the next pr_info() will cause issue.
Signed-off-by Chen Gang <[email protected]>
--- arch/mips/kernel/prom.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/mips/kernel/prom.c +1 -1
@@ -30,7 +30,7 @@ __init void mips_set_machine_name(const char *name)if (name ==NULL )return ; -strncpy (mips_machine_name, name,sizeof (mips_machine_name)); +strlcpy (mips_machine_name, name,sizeof (mips_machine_name));pr_info ("MIPS: machine is %s\n" ,mips_get_machine_name ()); }
Signature · 1 line
1.7.7.6
Quoted 15 lines · Chen Gang
For NUL terminated string, need always be sure of ended by zero.
Or the next
pr_info()will cause issue.Signed-off-by Chen Gang<[email protected]>--- arch/mips/kernel/prom.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/mips/kernel/prom.c +0
-0
arch/mips/kernel/prom.c __init void mips_set_machine_name(const char *name) · line 36
Quoted 8 lines
arch/mips/kernel/prom.c +1
-1@@ -30,7 +30,7 @@ __init void mips_set_machine_name(const char *name)if (name ==NULL )return ; -strncpy (mips_machine_name, name,sizeof (mips_machine_name)); +strlcpy (mips_machine_name, name,sizeof (mips_machine_name));pr_info ("MIPS: machine is %s\n" ,mips_get_machine_name ()); }
Acked-by John Crispin <[email protected]>