mmc: sdhci-s3c: fix the wrong register value when, clock is disabled
Subsystems (3)
Jaehoon Chung
maintainerPATCH v2 1/1 mmc: sdhci-s3c: fix the wrong register value when, clock is disabled
When use the QUIRK_NONSTANDARD_CLOCK, then never set to 0 at clock control register. This patch is fixed this problem.
---
Changelog v2:
- Rebased at the latest mmc tree
drivers/mmc/host/sdhci-s3c.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/mmc/host/sdhci-s3c.c +4 -1
@@ -297,8 +297,11 @@ static void sdhci_cmu_set_clock(struct sdhci_host *host, unsigned int clock)u16 clk =0 ;/* don't bother if the clock is going off */ -if (clock ==0 ) +if (clock ==0 ) { +sdhci_writew (host,0 ,SDHCI_CLOCK_CONTROL ); + host->clock = clock;return ; + }sdhci_s3c_set_clock (host, clock);
Signature · 1 line
1.7.9.5
Jaehoon Chung
maintainerDear Chris,
If you didn't have any comment, Could you merge this patch, plz?
Best Regards,
Jaehoon Chung
Quoted 30 lines · Jaehoon Chung
When use the
QUIRK_NONSTANDARD_CLOCK, then never set to 0 at clock control register. This patch is fixed this problem.Signed-off-by Jaehoon Chung <[email protected]Signed-off-by Kyungmin Park <[email protected]>---
Changelog v2:
- Rebased at the latest mmc treedrivers/mmc/host/sdhci-s3c.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/mmc/host/sdhci-s3c.c +4
-1@@ -297,8 +297,11 @@ static void sdhci_cmu_set_clock(struct sdhci_host *host, unsigned int clock)u16 clk =0 ;/* don't bother if the clock is going off */ -if (clock ==0 ) +if (clock ==0 ) { +sdhci_writew (host,0 ,SDHCI_CLOCK_CONTROL ); + host->clock = clock;return ; + }sdhci_s3c_set_clock (host, clock);
Hi Jaehoon,
Quoted 18 lines · Jaehoon Chung
When use the
QUIRK_NONSTANDARD_CLOCK, then never set to 0 at clock control register. This patch is fixed this problem.Signed-off-by Jaehoon Chung <[email protected]Signed-off-by Kyungmin Park <[email protected]>---
Changelog v2:
- Rebased at the latest mmc treedrivers/mmc/host/sdhci-s3c.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/mmc/host/sdhci-s3c.c +0
-0@@ -297,8 +297,11 @@ static void sdhci_cmu_set_clock(struct sdhci_host *host, unsigned int clock)u16 clk =0 ;
drivers/mmc/host/sdhci-s3c.c static void sdhci_cmu_set_clock(struct sdhci_host *host, unsigned int clock) · line 306
Quoted 10 lines
drivers/mmc/host/sdhci-s3c.c +4
-1/* don't bother if the clock is going off */ -if (clock ==0 ) +if (clock ==0 ) { +sdhci_writew (host,0 ,SDHCI_CLOCK_CONTROL ); + host->clock = clock;return ; + }sdhci_s3c_set_clock (host, clock);
You should change the comment too, since your patch invalidates it.
Thanks,
- Chris.
Signature · 2 lines
Chris Ball <[email protected]> <http://printf.net/> One Laptop Per Child
Jaehoon Chung
maintainerDear Chris,
I will change the comment, and re-send the patch.
Thanks Chris.
Best Regards,
Jaehoon Chung
Quoted 38 lines · Chris Ball
Hi Jaehoon,
Quoted 18 lines · Jaehoon Chung
When use the
QUIRK_NONSTANDARD_CLOCK, then never set to 0 at clock control register. This patch is fixed this problem.Signed-off-by Jaehoon Chung <[email protected]Signed-off-by Kyungmin Park <[email protected]>---
Changelog v2:
- Rebased at the latest mmc treedrivers/mmc/host/sdhci-s3c.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/mmc/host/sdhci-s3c.c +0
-0@@ -297,8 +297,11 @@ static void sdhci_cmu_set_clock(struct sdhci_host *host, unsigned int clock)u16 clk =0 ;drivers/mmc/host/sdhci-s3c.c static void sdhci_cmu_set_clock(struct sdhci_host *host, unsigned int clock) · line 306
Quoted 10 lines
drivers/mmc/host/sdhci-s3c.c +4
-1/* don't bother if the clock is going off */ -if (clock ==0 ) +if (clock ==0 ) { +sdhci_writew (host,0 ,SDHCI_CLOCK_CONTROL ); + host->clock = clock;return ; + }sdhci_s3c_set_clock (host, clock);You should change the comment too, since your patch invalidates it.
Thanks,
- Chris.