NFS inode cache zap on lock - please advice
Subsystems (2)
13.07.2013 00:52, [email protected] пишет:
Quoted 8 lines · Stanislav Kinsbursky
Quoted 5 lines
Thanks, Bruce!
I'll have atBTW, do you have any decisions what we will do with UMH tracker?
Crap, apologies, I completely dropped this. Have you looked at it again lately?
Don't worry, it's all right. And I added Jeff and mailing list to recipients.
I was thinking about using kernel_thread() instead of kthread_create().
This might work, because will give us kthread with same root and same capabilities as mount caller had.
What you, guys, think about it?
Quoted 10 lines · On Mon, 15 Jul 2013 11:16:39 +0400 Stanislav Kinsbursky…
13.07.2013 00:52, [email protected] пишет:
Quoted 8 lines · Stanislav Kinsbursky
Quoted 5 lines
Thanks, Bruce!
I'll have atBTW, do you have any decisions what we will do with UMH tracker?
Crap, apologies, I completely dropped this. Have you looked at it again lately?
Quoted 8 lines
Don't worry, it's all right. And I added Jeff and mailing list to recipients.
I was thinking about using
kernel_thread()instead ofkthread_create(). This might work, because will give us kthread with same root and same capabilities as mount caller had.What you, guys, think about it?
Well, it's not the caller of mount that we're concerned with here. It's the caller of rpc.nfsd. That program is going to make the kernel spawn a bunch of nfsd kthreads and then exit. So I guess the basic idea here is to preserve the namespace info, root and creds from that process before it exits. Spawning a kthread would work for that, and might be simplest, but we should weigh this idea carefully before we settle on it.
Let's assume for a moment that we want to do all of this in userspace instead (Eric B.'s first suggestion). I assume the kernel would need to pass a fd to the program so it can call setns() with it. Where would it get this fd, considering that we're calling this from a nfsd kthread?
What else would it need? Would it need a path to chroot() to? Credential info so it can call setuid/setgid?
Other caveats might be that the binary needn't exist in the container to which you're chrooting. That's not really a problem as long as all the libs get linked in before the program does the switcharoo, but it might make troubleshooting problems in this code difficult from a user sitting in that container.
Signature · 1 line
Jeff Layton <[email protected]>
15.07.2013 15:11, Jeff Layton пишет:
Quoted 32 lines
Quoted 8 lines · On Mon, 15 Jul 2013 11:16:39 +0400 Stanislav Kinsbursky…
13.07.2013 00:52, [email protected] пишет:
Quoted 7 lines · Stanislav Kinsbursky
Quoted 4 lines
Thanks, Bruce!
I'll have atBTW, do you have any decisions what we will do with UMH tracker?
Crap, apologies, I completely dropped this. Have you looked at it again lately?
Quoted 8 lines
Don't worry, it's all right. And I added Jeff and mailing list to recipients.
I was thinking about using
kernel_thread()instead ofkthread_create(). This might work, because will give us kthread with same root and same capabilities as mount caller had.What you, guys, think about it?
Well, it's not the caller of mount that we're concerned with here. It's the caller of rpc.nfsd. That program is going to make the kernel spawn a bunch of nfsd kthreads and then exit. So I guess the basic idea here is to preserve the namespace info, root and creds from that process before it exits. Spawning a kthread would work for that, and might be simplest, but we should weigh this idea carefully before we settle on it.
Let's assume for a moment that we want to do all of this in userspace instead (Eric B.'s first suggestion). I assume the kernel would need to pass a fd to the program so it can call
setns()with it. Where would it get this fd, considering that we're calling this from a nfsd kthread?
Quoted 9 lines
What else would it need? Would it need a path to
chroot()to? Credential info so it can call setuid/setgid?Other caveats might be that the binary needn't exist in the container to which you're chrooting. That's not really a problem as long as all the libs get linked in before the program does the switcharoo, but it might make troubleshooting problems in this code difficult from a user sitting in that container.
As far as I understand the user namespaces idea, the all it covers are process credentials.
And for running the binary we need only mount and path.
My first approach was to swap root in UMH init callback. This works. But doesn't take user namespaces into account at all.
If we assume, that a user, which is capable to run rpc.nfsd is also must be capable to run the UMH binary, then we can just forget about a user-namespace isolation and use this UMH init callback. It's cheap to implement. But it's not flawless, because looks like a dirty hack (which it is, actually). Another way (with taking of user namespaces into account) is a kernel thread, forked in process context (i.e. kernel_thread() call). This will give us all the same credentials, root and namespaces, as rpc.nfsd caller has, for the UMH binary caller. But this solution requires of local implementation of a ____call_usermodehelper() function content. And a bunch of it's calls are not exported to modules. So it's a hack again, which looks even worse to me.
IOW, I don't see any comfortable existent solution for this task. But the first one is just simpler.
And this is all because kernel thread are working in initial namespaces including file system root.
Quoted 41 lines · Stanislav Kinsbursky
15.07.2013 15:11, Jeff Layton пишет:
Quoted 40 lines
Quoted 8 lines · On Mon, 15 Jul 2013 11:16:39 +0400 Stanislav Kinsbursky…
13.07.2013 00:52, [email protected] пишет:
Quoted 7 lines · Stanislav Kinsbursky
Quoted 4 lines
Thanks, Bruce!
I'll have atBTW, do you have any decisions what we will do with UMH tracker?
Crap, apologies, I completely dropped this. Have you looked at it again lately?
Quoted 8 lines
Don't worry, it's all right. And I added Jeff and mailing list to recipients.
I was thinking about using
kernel_thread()instead ofkthread_create(). This might work, because will give us kthread with same root and same capabilities as mount caller had.What you, guys, think about it?
Well, it's not the caller of mount that we're concerned with here. It's the caller of rpc.nfsd. That program is going to make the kernel spawn a bunch of nfsd kthreads and then exit. So I guess the basic idea here is to preserve the namespace info, root and creds from that process before it exits. Spawning a kthread would work for that, and might be simplest, but we should weigh this idea carefully before we settle on it.
Let's assume for a moment that we want to do all of this in userspace instead (Eric B.'s first suggestion). I assume the kernel would need to pass a fd to the program so it can call
setns()with it. Where would it get this fd, considering that we're calling this from a nfsd kthread?What else would it need? Would it need a path to
chroot()to? Credential info so it can call setuid/setgid?Other caveats might be that the binary needn't exist in the container to which you're chrooting. That's not really a problem as long as all the libs get linked in before the program does the switcharoo, but it might make troubleshooting problems in this code difficult from a user sitting in that container.
If possible I'd really be happier if the userspace code didn't have to understand containers.
(And on the client side we need to do that if we want to support existing nfsidmap binaries, right?)
If the kernel could the fd and any other relevant information to userspace I don't see why it couldn't just set up the environment right itself.
Quoted 6 lines
As far as I understand the user namespaces idea, the all it covers are process credentials.
And for running the binary we need only mount and path. My first approach was to swap root in UMH init callback. This works. But doesn't take user namespaces into account at all.
If we assume, that a user, which is capable to run rpc.nfsd is also
Quoted 8 lines
must be capable to run the UMH binary, then we can just forget about a user-namespace isolation and use this UMH init callback. It's cheap to implement. But it's not flawless, because looks like a dirty hack (which it is, actually).
Another way (with taking of user namespaces into account) is a kernel thread, forked in process context (i.e.kernel_thread()call). This will give us all the same credentials, root and namespaces, as rpc.nfsd caller has, for the UMH binary caller.
This is essentially Eric's option #1 from
http://article.gmane.org/gmane.linux.kernel/1496016 ?
That sounds best to me.
Quoted 4 lines
But this solution requires of local implementation of a
____call_usermodehelper()function content. And a bunch of it's calls are not exported to modules. So it's a hack again, which looks even worse to me.
Why can't we implement whatever call_usermodehelper() variant we need and then export that?
--b.
Quoted 5 lines
IOW, I don't see any comfortable existent solution for this task. But the first one is just simpler.
And this is all because kernel thread are working in initial namespaces including file system root.