Skip to contentSkip to conversation

opensm: fix possible double free in osm_ucast_ftree.c

PATCH New Hal Rosenstock 1 participant 1 message Jun 11, 2013 InfiniBand

lore
Share & tools
lore

Hal Rosenstock

author
#0 lore raw

PATCH 2/6 opensm: fix possible double free in osm_ucast_ftree.c

Quoted 1 line

From 49f1a71299e4aa28a8319334c772525f67cbd1ca Mon Sep 17 00:00:00 2001

From: Dan Ben Yosef <danby-VPRAkNaXOzVWk0Htik3J/[email protected]>
Date: Thu, 16 Aug 2012 16:33:55 +0300
Subject: [PATCH 2/6] opensm: fix possible double free in osm_ucast_ftree.c

Only if cl_ptr_vector_at return "CL_SUCCESS" ,the pointer "p_port" needed to be freed

Signed-off-by Dan Ben Yosef <danby-VPRAkNaXOzVWk0Htik3J/[email protected]>
Signed-off-by Alex Netes <alexne-VPRAkNaXOzVWk0Htik3J/[email protected]>
---
 opensm/osm_ucast_ftree.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
opensm/osm_ucast_ftree.c +4 -4
index fecc902..dfcd418 100644
@@ -453,10 +453,10 @@ static void port_group_destroy(IN ftree_port_group_t * p_group)
 
 	/* remove all the elements of p_group->ports vector */
 	size = cl_ptr_vector_get_size(&p_group->ports);
-	for (i = 0; i < size; i++) {
-		cl_ptr_vector_at(&p_group->ports, i, (void *)&p_port);
-		port_destroy(p_port);
-	}
+	for (i = 0; i < size; i++)
+		if (cl_ptr_vector_at(&p_group->ports, i, (void *)&p_port) == CL_SUCCESS)
+			port_destroy(p_port);
+
 	cl_ptr_vector_destroy(&p_group->ports);
 	free(p_group);
 }				/* port_group_destroy() */
Signature · 6 lines
1.7.8.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html