Skip to contentSkip to conversation

mod filenames != modnames? (inconsistent name changing)

DISCUSSION Linda Walsh 2 participants 2 messages Jun 12, 2013 – Jun 16, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Should we have any expectation that a module name and it's filename should be equivalent?

I was writing an auto-complete script for modprobe so it wouldn't give me the option to double load a module (I'd have to manually type it in if I really wanted it).

Trouble is some modules with names w/underscores ('_') change register their names with a 'dash'.

Would it be too much trouble to ask that the same names be used in both places?

I have about 30 modules loaded now and out of that list, 2 are name changes:

acpi_cpufreq (filename acip-cpufreq.ko)
kvm_intel (filename kvm-intel.ko)

If I load a bunch more... I find more that change names.

Could the naming in the modules that do this be made consistent?

Not doing so makes automatically tying a mod-name to it's file tend toward being non-deterministic.

Many modules use '-' or '_' without being confused. It would be helpful if the few confused modules could get their identity straight. Is there a problem with making these names consistent?

#1 lore raw
Quoted 9 lines · Linda Walsh

Should we have any expectation that a module name and it's filename should be equivalent?

I was writing an auto-complete script for modprobe so it wouldn't give me the option to double load a module (I'd have to manually type it in if I really wanted it).

Trouble is some modules with names w/underscores ('_') change register their names with a 'dash'.

But modprobe kvm_intel already works. Just convert any - to _?

Quoted 2 lines

Would it be too much trouble to ask that the same names be used in both places?

Well, you could get kernel developers to rename their files with underscores. I've CC'd them.

We use _ because we turn the module names into identifiers; it's also the most common choice, and having both is just confusing.

Quoted 10 lines

I have about 30 modules loaded now and out of that list, 2 are name changes:

acpi_cpufreq (filename acip-cpufreq.ko)
kvm_intel (filename kvm-intel.ko)

If I load a bunch more... I find more that change names.

Could the naming in the modules that do this be made consistent?

Quoted 7 lines

Not doing so makes automatically tying a mod-name to it's file tend toward being non-deterministic.

Many modules use '-' or '_' without being confused. It would be helpful if the few confused modules could get their identity straight. Is there a problem with making these names consistent?

It shouldn't break anything to rename them, if there's consensus I'm happy to create a patch.

Cheers,
Rusty.