Skip to contentSkip to conversation

libibnetdisc/Makefile.am: Add missing makefile dependency

PATCH Applied Hal Rosenstock 2 participants 4 messages Jun 12, 2013 3 messages not in the archive InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libibnetdisc/Makefile.am: Add missing makefile dependency

---

libibnetdisc/Makefile.am +1 -0
index d05604f..2cfcc33 100644
@@ -35,6 +35,7 @@ libibnetdiscincludedir = $(includedir)/infiniband
 test_testleaks_SOURCES = test/testleaks.c
 test_testleaks_CFLAGS = -Wall $(DBGFLAGS)
 test_testleaks_LDFLAGS = -libnetdisc
+test_testleaks_DEPENDENCIES = libibnetdisc.la
 
 libibnetdiscinclude_HEADERS = $(srcdir)/include/infiniband/ibnetdisc.h \
 				$(srcdir)/include/infiniband/ibnetdisc_osd.h

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 51B855AF.1070607-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org

#2 lore raw

What is the error which this fixed?

I would think that the test_testleaks_LDFLAGS would take care of this?

Ira

Quoted 20 lines

-----Original Message-----
From: Hal Rosenstock [mailto:[email protected]]
Sent: Wednesday, June 12, 2013 4:04 AM
To: Weiny, Ira
Cc: linux-rdma ([email protected]); Doron Tsur
Subject: [PATCH infiniband-diags] libibnetdisc/Makefile.am: Add missing makefile dependency

---

libibnetdisc/Makefile.am index renamed from libibnetdisc/Makefile.am +0 -0

d05604f..2cfcc33 100644

libibnetdisc/Makefile.am +0 -0
@@ -35,6 +35,7 @@ libibnetdiscincludedir = $(includedir)/infiniband

test_testleaks_SOURCES = test/testleaks.c test_testleaks_CFLAGS = -Wall $(DBGFLAGS) test_testleaks_LDFLAGS = -libnetdisc

libibnetdisc/Makefile.am libibnetdiscincludedir = $(includedir)/infiniband · line 41

Quoted 4 lines
libibnetdisc/Makefile.am +1 -0
+test_testleaks_DEPENDENCIES = libibnetdisc.la
 
 libibnetdiscinclude_HEADERS = $(srcdir)/include/infiniband/ibnetdisc.h \
 				$(srcdir)/include/infiniband/ibnetdisc_osd.h

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 2807E5FD2F6FDA4886F6618EAC48510E0207CCEF-8k97q/[email protected]

#4 lore raw
Quoted 1 line · Ira

What is the error which this fixed?

It's an issue when parallel make is used (make -j) where this library might not have completed building first.

Quoted 1 line

I would think that the test_testleaks_LDFLAGS would take care of this?

I don't think so.

-- Hal

Quoted 24 lines

Ira

Quoted 22 lines

-----Original Message-----
From: Hal Rosenstock [mailto:[email protected]]
Sent: Wednesday, June 12, 2013 4:04 AM
To: Weiny, Ira
Cc: linux-rdma ([email protected]); Doron Tsur
Subject: [PATCH infiniband-diags] libibnetdisc/Makefile.am: Add missing makefile dependency

---

libibnetdisc/Makefile.am index renamed from libibnetdisc/Makefile.am +0 -0

d05604f..2cfcc33 100644

libibnetdisc/Makefile.am +0 -0
@@ -35,6 +35,7 @@ libibnetdiscincludedir = $(includedir)/infiniband

test_testleaks_SOURCES = test/testleaks.c test_testleaks_CFLAGS = -Wall $(DBGFLAGS) test_testleaks_LDFLAGS = -libnetdisc +test_testleaks_DEPENDENCIES = libibnetdisc.la

Quoted 3 lines
Quoted 2 lines

libibnetdiscinclude_HEADERS = $(srcdir)/include/infiniband/ibnetdisc.h \
$(srcdir)/include/infiniband/ibnetdisc_osd.h

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 51B8BE92.7000805-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org

Applied
#6 lore raw
Quoted 10 lines

-----Original Message-----
From: Hal Rosenstock [mailto:[email protected]]
Subject: Re: [PATCH infiniband-diags] libibnetdisc/Makefile.am: Add missing makefile dependency

Quoted 1 line · Ira

What is the error which this fixed?

It's an issue when parallel make is used (make -j) where this library might not have completed building first.

Ok, I've never hit this, just luck I guess. ;-)

Quoted 4 lines
Quoted 2 lines

I would think that the test_testleaks_LDFLAGS would take care of this?

I don't think so.

Ok, seems reasonable.

Thanks, applied,
Ira

Quoted 32 lines

-- Hal

Quoted 29 lines

Ira

Quoted 26 lines

-----Original Message-----
From: Hal Rosenstock [mailto:[email protected]]
Sent: Wednesday, June 12, 2013 4:04 AM
To: Weiny, Ira
Cc: linux-rdma ([email protected]); Doron Tsur
Subject: [PATCH infiniband-diags] libibnetdisc/Makefile.am: Add missing makefile dependency

---

libibnetdisc/Makefile.am +0 -0

index
d05604f..2cfcc33 100644

libibnetdisc/Makefile.am +0 -0
@@ -35,6 +35,7 @@ libibnetdiscincludedir = $(includedir)/infiniband

test_testleaks_SOURCES = test/testleaks.c test_testleaks_CFLAGS = -Wall
$(DBGFLAGS) test_testleaks_LDFLAGS = -libnetdisc

libibnetdisc/Makefile.am +1 -0
+test_testleaks_DEPENDENCIES = libibnetdisc.la
 
 libibnetdiscinclude_HEADERS = $(srcdir)/include/infiniband/ibnetdisc.h \
 				$(srcdir)/include/infiniband/ibnetdisc_osd.h

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html