Skip to contentSkip to conversation

btrfs-progs and btrfs code similar why ?

DISCUSSION Anand Jain 2 participants 3 messages Jun 13, 2013 – Jun 14, 2013 Btrfs file system

lore
Share & tools
lore

Anand Jain

author
#0 lore raw

Per wiki an idea seems to maintain same code (probably as much as possible) between btrfs-progs and btrfs

There must have been a/few critical advantage, but what are they ?

Thanks, Anand

#1 lore raw
Quoted 9 lines · Anand Jain

Per wiki an idea seems to maintain same code (probably as much as possible) between btrfs-progs and btrfs

There must have been a/few critical advantage, but what are they ?

Thanks, Anand

Because they work with the same on-disk structures, and need to perform many of the same tasks. So using the same code base means bugs get fixed once, features get written once, there is built-in consistency, more coverage, etc.

I was just looking at an ext4 bug tonight where offline vs. online resize result in different filesystem images. In one case it leads to a bug, in the other it doesn't. The complex resize code is implemented twice, and implemented differently.

Less code is good. Consistency is good.

-Eric

author
#2 lore raw
Quoted 5 lines

Because they work with the same on-disk structures, and need to perform many of the same tasks. So using the same code base means bugs get fixed once, features get written once, there is built-in consistency, more coverage, etc.

yes. Thanks Eric.

- Anand