libqmi: new package
PATCH 1/1 libqmi: new package
libqmi is a glib-based library for talking to WWAN modems and devices which speak the Qualcomm MSM Interface (QMI) protocol.
--- package/Config.in | 1 + package/libqmi/Config.in | 6 ++++++ package/libqmi/libqmi.mk | 24 ++++++++++++++++++++++++ 3 files changed, 31 insertions(+) create mode 100644 package/libqmi/Config.in create mode 100644 package/libqmi/libqmi.mk
package/Config.in +1 -0
@@ -484,6 +484,7 @@ source "package/libhid/Config.in" source "package/libiqrf/Config.in" source "package/libnfc/Config.in" source "package/libnfc-llcp/Config.in" +source "package/libqmi/Config.in" source "package/libserial/Config.in" source "package/libusb/Config.in" source "package/libusb-compat/Config.in"
package/libqmi/Config.in new file +6 -0
@@ -0,0 +1,6 @@ +config BR2_PACKAGE_LIBQMI + bool "libqmi" + select BR2_PACKAGE_LIBGLIB2 + help + libqmi is a glib-based library for talking to WWAN modems and devices + which speak the Qualcomm MSM Interface (QMI) protocol.
package/libqmi/libqmi.mk new file +24 -0
@@ -0,0 +1,24 @@ +################################################################################ +# +# libqmi +# +################################################################################ + +LIBQMI_VERSION = 1.4.0 +LIBQMI_SITE = http://cgit.freedesktop.org/libqmi/snapshot/ +LIBQMI_SOURCE = libqmi-$(LIBQMI_VERSION).tar.gz +LIBQMI_LICENSE = LGPLv2+ (library), GPLv2+ (programs) +LIBQMI_LICENSE_FILES = COPYING +LIBQMI_INSTALL_STAGING = YES +LIBQMI_AUTORECONF = YES + +LIBQMI_DEPENDENCIES += libglib2 + +define LIBQMI_CREATE_GTK_DOC_MAKE + $(RM) $(@D)/gtk-doc.make + echo -e "EXTRA_DIST =\nCLEANFILES =" > $(@D)/gtk-doc.make +endef + +LIBQMI_POST_PATCH_HOOKS += LIBQMI_CREATE_GTK_DOC_MAKE + +$(eval $(autotools-package))
Signature · 19 lines
1.8.1.2 -- Dipl.-Inf. (FH) Patrick Ziegler University Of Applied Sciences Kaiserslautern Amerikastrasse 1 D-66482 Zweibruecken Germany Phone: +49 631 3724 5526 Mail: patrick.ziegler at fh-kl.de PGP KeyID 0xB4796B8C http://www.fh-kl.de http://www.fh-kl.de/fachbereiche/imst/iuk-knowhow.html
PATCH 1/1 libqmi: new package
Dear Patrick Ziegler,
package/libqmi/Config.in line 3
Quoted 3 lines · Patrick Ziegler
package/libqmi/Config.in new file +3
-0+config BR2_PACKAGE_LIBQMI + bool "libqmi" + select BR2_PACKAGE_LIBGLIB2
You need to propagate the "depends on" that libglib2 has, i.e WCHAR.
package/libqmi/Config.in line 6
Quoted 3 lines
package/libqmi/Config.in new file +3
-0+ help + libqmi is a glib-based library for talking to WWAN modems and devices + which speak the Qualcomm MSM Interface (QMI) protocol.
Upstream URL missing.
package/libqmi/libqmi.mk line 9
Quoted 3 lines
package/libqmi/libqmi.mk new file +3
-0+LIBQMI_VERSION = 1.4.0 +LIBQMI_SITE = http://cgit.freedesktop.org/libqmi/snapshot/ +LIBQMI_SOURCE = libqmi-$(LIBQMI_VERSION).tar.gz
This is the default, so you could remove this line.
package/libqmi/libqmi.mk line 13
Quoted 4 lines
package/libqmi/libqmi.mk new file +4
-0+LIBQMI_LICENSE = LGPLv2+ (library), GPLv2+ (programs) +LIBQMI_LICENSE_FILES = COPYING +LIBQMI_INSTALL_STAGING = YES +LIBQMI_AUTORECONF = YES
It would be good to have a comment that explains why autoreconf is needed, i.e "The tarball is a Git snapshot, doesn't contain the genrated configure script and Makefile" or something like this.
Quoted 1 line
+LIBQMI_DEPENDENCIES += libglib2
You could use a = here.
Best regards,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 libqmi: new package
Dear Thomas Petazzoni,
Quoted 30 lines · Thomas Petazzoni
package/libqmi/Config.in line 3
Quoted 3 lines · Patrick Ziegler
package/libqmi/Config.in new file +3
-0+config BR2_PACKAGE_LIBQMI + bool "libqmi" + select BR2_PACKAGE_LIBGLIB2You need to propagate the "depends on" that libglib2 has, i.e WCHAR.
package/libqmi/Config.in line 6
Quoted 3 lines
package/libqmi/Config.in new file +3
-0+ help + libqmi is a glib-based library for talking to WWAN modems and devices + which speak the Qualcomm MSM Interface (QMI) protocol.Upstream URL missing.
package/libqmi/libqmi.mk line 9
Quoted 3 lines
package/libqmi/libqmi.mk new file +3
-0+LIBQMI_VERSION = 1.4.0 +LIBQMI_SITE = http://cgit.freedesktop.org/libqmi/snapshot/ +LIBQMI_SOURCE = libqmi-$(LIBQMI_VERSION).tar.gzThis is the default, so you could remove this line.
package/libqmi/libqmi.mk line 13
Quoted 4 lines
package/libqmi/libqmi.mk new file +4
-0+LIBQMI_LICENSE = LGPLv2+ (library), GPLv2+ (programs) +LIBQMI_LICENSE_FILES = COPYING +LIBQMI_INSTALL_STAGING = YES +LIBQMI_AUTORECONF = YESIt would be good to have a comment that explains why autoreconf is needed, i.e "The tarball is a Git snapshot, doesn't contain the genrated configure script and
Makefile" or something like this.
Quoted 4 lines
Quoted 1 line
+LIBQMI_DEPENDENCIES += libglib2
You could use a = here.
thanks for having a look on this patch.
While I was searching for the best upstream URL, I've found a better source tarball that doesn't need autoreconf. I will update my patch and resend.
Best regards
Patrick
Signature · 15 lines
Dipl.-Inf. (FH) Patrick Ziegler University Of Applied Sciences Kaiserslautern Amerikastrasse 1 D-66482 Zweibruecken Germany Phone: +49 631 3724 5526 Mail: patrick.ziegler at fh-kl.de PGP KeyID 0xB4796B8C http://www.fh-kl.de http://www.fh-kl.de/fachbereiche/imst/iuk-knowhow.html