dlm: config: using strlcpy instead of strncpy

PATCH New Zhao Hongjiang 1 participant 1 message Jun 20, 2013 Distributed lock manager (DLM)

lore

Share & tools

lore

Zhao Hongjiang

author

2013-06-20 10:59 UTC #0 lore raw

PATCH 1/1 dlm: config: using strlcpy instead of strncpy

for NUL terminated string, need alway set '\0' in the end.

Signed-off-by Zhao Hongjiang <[email protected]>

---
 fs/dlm/config.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

fs/dlm/config.c +3 -2

index 7d58d5b..76feb4b 100644
@@ -138,8 +138,9 @@ static ssize_t cluster_cluster_name_read(struct dlm_cluster *cl, char *buf)
 static ssize_t cluster_cluster_name_write(struct dlm_cluster *cl,
 					  const char *buf, size_t len)
 {
-	strncpy(dlm_config.ci_cluster_name, buf, DLM_LOCKSPACE_LEN);
-	strncpy(cl->cl_cluster_name, buf, DLM_LOCKSPACE_LEN);
+	strlcpy(dlm_config.ci_cluster_name, buf,
+				sizeof(dlm_config.ci_cluster_name));
+	strlcpy(cl->cl_cluster_name, buf, sizeof(cl->cl_cluster_name));
 	return len;
 }

Signature · 1 line

1.7.1