arch: m32r: include: asm: add "dma-mapping-common.h"

PATCH In review Chen Gang 2 participants 4 messages Jun 27, 2013 Generic include/asm header files

lore

Share & tools

lore

Chen Gang

author

2013-06-27 04:51 UTC #0 lore raw

PATCH 1/1 arch: m32r: include: asm: add "dma-mapping-common.h"

Need add generic "dma-mapping-common.h", or compiling may fail.

The related error (with allmodconfig):

CC [M] net/irda/irlan/irlan_eth.o
drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’:
drivers/media/v4l2-core/videobuf2-dma-contig.c:202:2: error: implicit declaration of function ‘dma_mmap_coherent’ [-Werror=implicit-function-declaration] drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_get_base_sgt’:
drivers/media/v4l2-core/videobuf2-dma-contig.c:385:2: error: implicit declaration of function ‘dma_get_sgtable’ [-Werror=implicit-function-declaration]

Signed-off-by Chen Gang <[email protected]>

---
 arch/m32r/include/asm/Kbuild |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

arch/m32r/include/asm/Kbuild +1 -0

index bebdc36..fecca22 100644
@@ -1,5 +1,6 @@
 
 generic-y += clkdev.h
+generic-y += dma-mapping-common.h
 generic-y += exec.h
 generic-y += module.h
 generic-y += trace_clock.h

Signature · 1 line

1.7.7.6

Arnd Bergmann

maintainer

2013-06-27 08:29 UTC #1 lore raw

Quoted 4 lines · On Thursday 27 June 2013 12:50:59 Chen Gang wrote:

Need add generic "dma-mapping-common.h", or compiling may fail.
The related error (with allmodconfig):

Quoted 8 lines

CC [M] net/irda/irlan/irlan_eth.o
drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’:
drivers/media/v4l2-core/videobuf2-dma-contig.c:202:2: error: implicit declaration of function ‘dma_mmap_coherent’ [-Werror=implicit-function-declaration] drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_get_base_sgt’:
drivers/media/v4l2-core/videobuf2-dma-contig.c:385:2: error: implicit declaration of function ‘dma_get_sgtable’ [-Werror=implicit-function-declaration]
Signed-off-by Chen Gang <[email protected]>

m32r does not provide the "common" version of the dma mapping API, so this is certainly wrong.

Arnd

Chen Gang

author

2013-06-27 09:28 UTC #2 lore raw

Quoted 12 lines · Arnd Bergmann

Quoted 11 lines · On Thursday 27 June 2013 12:50:59 Chen Gang wrote:
Need add generic "dma-mapping-common.h", or compiling may fail.
The related error (with allmodconfig):
CC [M] net/irda/irlan/irlan_eth.o
drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’:
drivers/media/v4l2-core/videobuf2-dma-contig.c:202:2: error: implicit declaration of function ‘dma_mmap_coherent’ [-Werror=implicit-function-declaration] drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_get_base_sgt’:
drivers/media/v4l2-core/videobuf2-dma-contig.c:385:2: error: implicit declaration of function ‘dma_get_sgtable’ [-Werror=implicit-function-declaration]

Quoted 5 lines

Quoted 1 line
Signed-off-by Chen Gang <[email protected]>
m32r does not provide the "common" version of the dma mapping API, so this is certainly wrong.

But m32r really has pci.h, and also can cause this issue.

Thanks.

Signature · 1 line

Chen Gang

Chen Gang

author

2013-06-27 09:41 UTC #3 lore raw

Quoted 13 lines · Chen Gang

Quoted 12 lines · Arnd Bergmann
Quoted 12 lines · On Thursday 27 June 2013 12:50:59 Chen Gang wrote:
Quoted 11 lines
Quoted 11 lines
Need add generic "dma-mapping-common.h", or compiling may fail.
The related error (with allmodconfig):
CC [M] net/irda/irlan/irlan_eth.o
drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’:
drivers/media/v4l2-core/videobuf2-dma-contig.c:202:2: error: implicit declaration of function ‘dma_mmap_coherent’ [-Werror=implicit-function-declaration] drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_get_base_sgt’:
drivers/media/v4l2-core/videobuf2-dma-contig.c:385:2: error: implicit declaration of function ‘dma_get_sgtable’ [-Werror=implicit-function-declaration]

Quoted 5 lines

Quoted 5 lines
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Signed-off-by Chen Gang <[email protected]>
m32r does not provide the "common" version of the dma mapping API, so this is certainly wrong.

Oh, sorry, the reply below is incorrect, I will check it, again, thanks.

Quoted 1 line

But m32r really has pci.h, and also can cause this issue.

Signature · 1 line

Chen Gang