xfs: clean up unused codes at xfs_bulkstat()
PATCH 1/1 xfs: clean up unused codes at xfs_bulkstat()
From: Jie Liu <[email protected]>
There are some unused codes at xfs_bulkstat():
- Variable bp is defined to point to the on-disk inode cluster buffer, but it proved to be of no practical help.
- We process the chunks of good inodes which were fetched by iterating btree records from an AG. When processing inodes from each chunk, the code recomputing agbno if run into the first inode of a cluster, however, the agbno is not being used thereafter.
This patch tries to clean up those things.
--- fs/xfs/xfs_itable.c | 28 +--------------------------- 1 file changed, 1 insertion(+), 27 deletions(-)
fs/xfs/xfs_itable.c +1 -27
@@ -221,7 +221,6 @@ xfs_bulkstat(char __user *ubufp;/* pointer into user's buffer */ int ubelem;/* spaces used in user's buffer */ int ubused;/* bytes used by formatter */ -xfs_buf_t *bp;/* ptr to on-disk inode cluster buf */ /* * Get the last inode value, see if there's nothing to do.
@@ -263,7 +262,6 @@ xfs_bulkstat( rval =0 ;while (XFS_BULKSTAT_UBLEFT (ubleft) && agno < mp->m_sb.sb_agcount) {cond_resched (); - bp =NULL ; error =xfs_ialloc_read_agi (mp,NULL , agno, &agbp);if (error) {/*
@@ -433,27 +431,7 @@ xfs_bulkstat( irbp->ir_freecount <XFS_INODES_PER_CHUNK ; chunkidx++, clustidx++, agino++) {ASSERT (chunkidx <XFS_INODES_PER_CHUNK ); -/* -* Recompute agbno if this is the -* first inode of the cluster. -* -* Careful with clustidx. There can be -* multiple clusters per chunk, a single -* cluster per chunk or a cluster that has -* inodes represented from several different -* chunks (if blocksize is large). -* -* Because of this, the starting clustidx is -* initialized to zero in this loop but must -* later be reset after reading in the cluster -* buffer. -*/ -if ((chunkidx & (nicluster -1 )) ==0 ) { - agbno =XFS_AGINO_TO_AGBNO (mp, - irbp->ir_startino) + - ((chunkidx & nimask) >> - mp->m_sb.sb_inopblog); - } + ino =XFS_AGINO_TO_INO (mp, agno, agino);/* * Skip if this inode is free.
@@ -499,10 +477,6 @@ xfs_bulkstat(cond_resched (); } - -if (bp) -xfs_buf_relse (bp); -/* * Set up for the next loop iteration. */
Signature · 6 lines
1.7.9.5 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 7 lines · Jeff Liu
From: Jie Liu <[email protected]>
There are some unused codes at
xfs_bulkstat():- Variable bp is defined to point to the on-disk inode cluster buffer, but it proved to be of no practical help.
Quoted 8 lines
- We process the chunks of good inodes which were fetched by iterating btree records from an AG. When processing inodes from each chunk, the code recomputing agbno if run into the first inode of a cluster, however, the agbno is not being used thereafter.
This patch tries to clean up those things.
Signed-off-by Jie Liu <[email protected]>
Signature · 7 lines
Dave Chinner [email protected] _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Ben Myers
AppliedQuoted 13 lines · Dave Chinner
Quoted 12 lines · Jeff Liu
From: Jie Liu <[email protected]>
There are some unused codes at
xfs_bulkstat():- Variable bp is defined to point to the on-disk inode cluster buffer, but it proved to be of no practical help.
- We process the chunks of good inodes which were fetched by iterating btree records from an AG. When processing inodes from each chunk, the code recomputing agbno if run into the first inode of a cluster, however, the agbno is not being used thereafter.
Quoted 5 lines
Quoted 3 lines
This patch tries to clean up those things.
Signed-off-by Jie Liu <[email protected]>Reviewed-by Dave Chinner <[email protected]>
Applied.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs