fs/bio-integrity: fix a potential mem leak

PATCH Superseded Gu Zheng 1 participant 1 message Jul 24, 2013 VFS

lore

Share & tools

lore

Gu Zheng

author

2013-07-24 02:27 UTC #0 lore raw

PATCH 1/1 fs/bio-integrity: fix a potential mem leak

Free the bio_integrity_pool in the fail path of biovec_create_pool in function bioset_integrity_create().

Signed-off-by Gu Zheng <[email protected]>

---
 fs/bio-integrity.c |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

fs/bio-integrity.c +5 -4

index 8fb4291..6025084 100644
@@ -716,13 +716,14 @@ int bioset_integrity_create(struct bio_set *bs, int pool_size)
 		return 0;
 
 	bs->bio_integrity_pool = mempool_create_slab_pool(pool_size, bip_slab);
-
-	bs->bvec_integrity_pool = biovec_create_pool(bs, pool_size);
-	if (!bs->bvec_integrity_pool)
+	if (!bs->bio_integrity_pool)
 		return -1;
 
-	if (!bs->bio_integrity_pool)
+	bs->bvec_integrity_pool = biovec_create_pool(bs, pool_size);
+	if (!bs->bvec_integrity_pool) {
+		mempool_destroy(bs->bio_integrity_pool);
 		return -1;
+	}
 
 	return 0;
 }

Signature · 1 line

1.7.7