memcg: remove redundant code in mem_cgroup_force_empty_write()
Subsystems (3)
PATCH 1/1 memcg: remove redundant code in mem_cgroup_force_empty_write()
vfs guarantees the cgroup won't be destroyed, so it's redundant to get a css reference.
Signed-off-by Li Zefan <[email protected]>
--- mm/memcontrol.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
mm/memcontrol.c +1 -6
@@ -5015,15 +5015,10 @@ static int mem_cgroup_force_empty(struct mem_cgroup *memcg)static int mem_cgroup_force_empty_write (struct cgroup *cont,unsigned int event) {struct mem_cgroup *memcg =mem_cgroup_from_cont (cont); -int ret;if (mem_cgroup_is_root (memcg))return -EINVAL ; -css_get (&memcg->css); - ret =mem_cgroup_force_empty (memcg); -css_put (&memcg->css); - -return ret; +return mem_cgroup_force_empty (memcg); }
Signature · 1 line
1.8.0.2
Quoted 4 lines · Li Zefan
vfs guarantees the cgroup won't be destroyed, so it's redundant to get a css reference.
Signed-off-by Li Zefan <[email protected]>
Acked-by Michal Hocko <[email protected]>
Thanks!
Quoted 27 lines
--- mm/memcontrol.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)mm/memcontrol.c +1
-6@@ -5015,15 +5015,10 @@ static int mem_cgroup_force_empty(struct mem_cgroup *memcg)static int mem_cgroup_force_empty_write (struct cgroup *cont,unsigned int event) {struct mem_cgroup *memcg =mem_cgroup_from_cont (cont); -int ret;if (mem_cgroup_is_root (memcg))return -EINVAL ; -css_get (&memcg->css); - ret =mem_cgroup_force_empty (memcg); -css_put (&memcg->css); - -return ret; +return mem_cgroup_force_empty (memcg); }Signature · 1 line
1.8.0.2
Signature · 8 lines
Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>