Skip to contentSkip to conversation

Zynq clk fixes

DISCUSSION Michal Simek 3 participants 7 messages Jul 26, 2013 – Aug 15, 2013

lore
Share & tools
lore
#0 lore raw

Hi Mike, [cc: Arnd and Olof]

Soren has found two bug fixes in zynq clk code. Can you please add these two patches to your tree? Will be great if you can add them to v3.11.

Arnd, Olof: I expect that all these clock changes should go through Mike. If I am wrong please let me know.

Thanks,
Michal

The following changes since commit ad81f0545ef01ea651886dddac4bef6cec930092:

Linux 3.11-rc1 (2013-07-14 15:18:27 -0700)

are available in the git repository at:

git://git.xilinx.com/linux-xlnx.git tags/zynq-clk-fixes-for-3.11

for you to fetch changes up to 97d58aef394831f6f0583653de29e03886a0e09e:

clk/zynq/clkc: Add CLK_SET_RATE_PARENT flag to ethernet muxes (2013-07-17 08:36:53 +0200)

----------------------------------------------------------------
arm: Xilinx Zynq clock fixes for v3.11

- Fix watchdog clock registration
- Fix gem clock propagation

----------------------------------------------------------------
Soren Brinkmann (2):
clk/zynq/clkc: Add dedicated spinlock for the SWDT clk/zynq/clkc: Add CLK_SET_RATE_PARENT flag to ethernet muxes

 drivers/clk/zynq/clkc.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)
Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130726/f30192d3/attachment.sig>
#1 lore raw

Quoting Michal Simek (2013-07-26 05:09:58)

Quoted 8 lines

Hi Mike, [cc: Arnd and Olof]

Soren has found two bug fixes in zynq clk code. Can you please add these two patches to your tree? Will be great if you can add them to v3.11.

Arnd, Olof: I expect that all these clock changes should go through Mike. If I am wrong please let me know.

Looks right to me. Do these fix regressions in the current -rc cycle?

Regards,
Mike

Quoted 37 lines

Thanks,
Michal

The following changes since commit ad81f0545ef01ea651886dddac4bef6cec930092:

Linux 3.11-rc1 (2013-07-14 15:18:27 -0700)

are available in the git repository at:

git://git.xilinx.com/linux-xlnx.git tags/zynq-clk-fixes-for-3.11

for you to fetch changes up to 97d58aef394831f6f0583653de29e03886a0e09e:

clk/zynq/clkc: Add CLK_SET_RATE_PARENT flag to ethernet muxes (2013-07-17 08:36:53 +0200)

----------------------------------------------------------------
arm: Xilinx Zynq clock fixes for v3.11

- Fix watchdog clock registration
- Fix gem clock propagation

----------------------------------------------------------------
Soren Brinkmann (2):
clk/zynq/clkc: Add dedicated spinlock for the SWDT clk/zynq/clkc: Add CLK_SET_RATE_PARENT flag to ethernet muxes

 drivers/clk/zynq/clkc.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)
Signature · 5 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
#2 lore raw
Quoted 11 lines · Mike Turquette

Quoting Michal Simek (2013-07-26 05:09:58)

Quoted 8 lines

Hi Mike, [cc: Arnd and Olof]

Soren has found two bug fixes in zynq clk code. Can you please add these two patches to your tree? Will be great if you can add them to v3.11.

Arnd, Olof: I expect that all these clock changes should go through Mike. If I am wrong please let me know.

Looks right to me. Do these fix regressions in the current -rc cycle?

I doubt there are real regressions. But since it's still early in the release cycle and the driver was added in this merge window, I'd prefer having it hit a release kernel with these fixes included.

S?ren

#3 lore raw

Quoting S?ren Brinkmann (2013-07-26 14:11:52)

Quoted 8 lines · Mike Turquette
Quoted 7 lines

Quoting Michal Simek (2013-07-26 05:09:58)

Quoted 6 lines

Hi Mike, [cc: Arnd and Olof]

Soren has found two bug fixes in zynq clk code. Can you please add these two patches to your tree? Will be great if you can add them to v3.11.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Arnd, Olof: I expect that all these clock changes should go through Mike. If I am wrong please let me know.

Looks right to me. Do these fix regressions in the current -rc cycle?

I doubt there are real regressions. But since it's still early in the release cycle and the driver was added in this merge window, I'd prefer having it hit a release kernel with these fixes included.

I've taken these into clk-fixes and added the following to the changelog for each patch:

"This does not fix a specific regression but the clock driver was merged for 3.11-rc1, so best to fix the known bugs before the release."

Regards,
Mike

Quoted 2 lines

S?ren

#4 lore raw
Quoted 18 lines · Mike Turquette

Quoting S?ren Brinkmann (2013-07-26 14:11:52)

Quoted 8 lines · Mike Turquette
Quoted 7 lines

Quoting Michal Simek (2013-07-26 05:09:58)

Quoted 6 lines

Hi Mike, [cc: Arnd and Olof]

Soren has found two bug fixes in zynq clk code. Can you please add these two patches to your tree? Will be great if you can add them to v3.11.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Arnd, Olof: I expect that all these clock changes should go through Mike. If I am wrong please let me know.

Looks right to me. Do these fix regressions in the current -rc cycle?

I doubt there are real regressions. But since it's still early in the release cycle and the driver was added in this merge window, I'd prefer having it hit a release kernel with these fixes included.

Quoted 5 lines

I've taken these into clk-fixes and added the following to the changelog for each patch:

"This does not fix a specific regression but the clock driver was merged for 3.11-rc1, so best to fix the known bugs before the release."

Thanks.

S?ren

#5 lore raw
In reply to Mike Turquette

Hi Mike,

Quoted 18 lines · Mike Turquette

Quoting S?ren Brinkmann (2013-07-26 14:11:52)

Quoted 8 lines · Mike Turquette
Quoted 7 lines

Quoting Michal Simek (2013-07-26 05:09:58)

Quoted 6 lines

Hi Mike, [cc: Arnd and Olof]

Soren has found two bug fixes in zynq clk code. Can you please add these two patches to your tree? Will be great if you can add them to v3.11.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Arnd, Olof: I expect that all these clock changes should go through Mike. If I am wrong please let me know.

Looks right to me. Do these fix regressions in the current -rc cycle?

I doubt there are real regressions. But since it's still early in the release cycle and the driver was added in this merge window, I'd prefer having it hit a release kernel with these fixes included.

Quoted 5 lines

I've taken these into clk-fixes and added the following to the changelog for each patch:

"This does not fix a specific regression but the clock driver was merged for 3.11-rc1, so best to fix the known bugs before the release."

Can you please tell me where you have added these two patches?
clk/zynq/clkc: Add dedicated spinlock for the SWDT clk/zynq/clkc: Add CLK_SET_RATE_PARENT flag to ethernet muxes

I can't see them in clk-fixes branch (this branch is pretty obsolete).
http://git.linaro.org/gitweb?p=people/mturquette/linux.git;a=summary

Thanks,
Michal

Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130813/a5eb9a6a/attachment.sig>
#6 lore raw

Quoting Michal Simek (2013-08-13 07:30:16)

Quoted 27 lines

Hi Mike,

Quoted 18 lines · Mike Turquette

Quoting S?ren Brinkmann (2013-07-26 14:11:52)

Quoted 8 lines · Mike Turquette
Quoted 7 lines

Quoting Michal Simek (2013-07-26 05:09:58)

Quoted 6 lines

Hi Mike, [cc: Arnd and Olof]

Soren has found two bug fixes in zynq clk code. Can you please add these two patches to your tree? Will be great if you can add them to v3.11.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Arnd, Olof: I expect that all these clock changes should go through Mike. If I am wrong please let me know.

Looks right to me. Do these fix regressions in the current -rc cycle?

I doubt there are real regressions. But since it's still early in the release cycle and the driver was added in this merge window, I'd prefer having it hit a release kernel with these fixes included.

Quoted 5 lines

I've taken these into clk-fixes and added the following to the changelog for each patch:

"This does not fix a specific regression but the clock driver was merged for 3.11-rc1, so best to fix the known bugs before the release."

Quoted 6 lines

Can you please tell me where you have added these two patches?
clk/zynq/clkc: Add dedicated spinlock for the SWDT clk/zynq/clkc: Add CLK_SET_RATE_PARENT flag to ethernet muxes

I can't see them in clk-fixes branch (this branch is pretty obsolete).
http://git.linaro.org/gitweb?p=people/mturquette/linux.git;a=summary

Those have been sent off to Linus in the clk-fixes-for-linus tag.

Regards,
Mike

Quoted 11 lines

Thanks,
Michal

Signature · 5 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform