fbdev: fix build warning in vga16fb.c

PATCH In review Xishi Qiu 2 participants 2 messages Jul 31, 2013 Framebuffer layer

Share & tools

Xishi Qiu

author

2013-07-31 03:21 UTC #0 lore raw

PATCH 1/1 fbdev: fix build warning in vga16fb.c

When building v3.11-rc3, I get the following warning:
...
drivers/video/vga16fb.c: In function ‘vga16fb_destroy’:
drivers/video/vga16fb.c:1268: warning: unused variable ‘dev’
...

Signed-off-by Xishi Qiu <[email protected]>

---
 drivers/video/vga16fb.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

drivers/video/vga16fb.c +0 -1

index 830ded4..2827333 100644
@@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
 
 static void vga16fb_destroy(struct fb_info *info)
 {
-	struct platform_device *dev = container_of(info->device, struct platform_device, dev);
 	iounmap(info->screen_base);
 	fb_dealloc_cmap(&info->cmap);
 	/* XXX unshare VGA regions */

Signature · 1 line

1.7.1

Gu Zheng

2013-07-31 03:28 UTC #1 lore raw

Hoho, Tomi has applied the patch from Lius to fix this warning. And this is the sixth patch to fix the same issue since last week.

Thanks,
Gu

Quoted 23 lines · Xishi Qiu

When building v3.11-rc3, I get the following warning:
...
drivers/video/vga16fb.c: In function ‘vga16fb_destroy’:
drivers/video/vga16fb.c:1268: warning: unused variable ‘dev’
...
Signed-off-by Xishi Qiu <[email protected]>
---
 drivers/video/vga16fb.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/video/vga16fb.c +0 -1
index 830ded4..2827333 100644
@@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
 
 static void vga16fb_destroy(struct fb_info *info)
 {
-	struct platform_device *dev = container_of(info->device, struct platform_device, dev);
 	iounmap(info->screen_base);
 	fb_dealloc_cmap(&info->cmap);
 	/* XXX unshare VGA regions */