ocfs2: add the missing return value check of ocfs2_xattr_get_clusters
PATCH 1/1 ocfs2: add the missing return value check of ocfs2_xattr_get_clusters
In ocfs2_xattr_value_attach_refcount(), if error occurs when calling ocfs2_xattr_get_clusters(), it will go with unexpected behavior since local variables p_cluster, num_clusters and ext_flags are declared without initialization.
Signed-off-by Joseph Qi <[email protected]>
--- fs/ocfs2/xattr.c | 4 ++++ 1 file changed, 4 insertions(+)
fs/ocfs2/xattr.c +4 -0
@@ -5889,6 +5889,10 @@ static int ocfs2_xattr_value_attach_refcount(struct inode *inode,while (cpos < clusters) { ret =ocfs2_xattr_get_clusters (inode, cpos, &p_cluster, &num_clusters, el, &ext_flags); +if (ret) { +mlog_errno (ret); +break ; + } cpos += num_clusters;if ((ext_flags &OCFS2_EXT_REFCOUNTED ))
Signature · 1 line
1.7.9.7
PATCH 1/1 ocfs2: add the missing return value check of ocfs2_xattr_get_clusters
Quoted 6 lines · Joseph Qi
In
ocfs2_xattr_value_attach_refcount(), if error occurs when callingocfs2_xattr_get_clusters(), it will go with unexpected behavior since local variablesp_cluster,num_clustersandext_flagsare declared without initialization.Signed-off-by Joseph Qi <[email protected]>
Looks good, thanks!
Acked-by Jie Liu <[email protected]>
Quoted 19 lines
--- fs/ocfs2/xattr.c | 4 ++++ 1 file changed, 4 insertions(+)fs/ocfs2/xattr.c +4
-0@@ -5889,6 +5889,10 @@ static int ocfs2_xattr_value_attach_refcount(struct inode *inode,while (cpos < clusters) { ret =ocfs2_xattr_get_clusters (inode, cpos, &p_cluster, &num_clusters, el, &ext_flags); +if (ret) { +mlog_errno (ret); +break ; + } cpos += num_clusters;if ((ext_flags &OCFS2_EXT_REFCOUNTED ))