Skip to content Skip to conversation

xfsprogs: fix agcnts leak in xfs_repair's scan_ags

PATCH In review Eric Sandeen 2 participants 2 messages Aug 1, 2013

Share & tools

Eric Sandeen

author

2013-08-01 02:25 UTC #0 lore raw

PATCH 1/1 xfsprogs: fix agcnts leak in xfs_repair's scan_ags

agcnts is malloc'd but never freed in this function.

Coverity found this.

Signed-off-by Eric Sandeen <[email protected]>

---

repair/scan.c +2 -0

index 76bb7f1..4040f53 100644
@@ -1367,6 +1367,8 @@ scan_ags(
 		ifreecount += agcnts[i].ifreecount;
 	}
 
+	free(agcnts);
+
 	/*
 	 * Validate that our manual counts match the superblock.
 	 */

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Mark Tinguely

Reviewed-by on v1 1/1

2013-08-01 14:56 UTC #1 lore raw

Quoted 7 lines · Eric Sandeen

agcnts is malloc'd but never freed in this function.
Coverity found this.
Signed-off-by Eric Sandeen<[email protected]>
---

Looks good.

Reviewed-by Mark Tinguely <[email protected]>

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs