net: ucc_geth: use platform_{get,set}_drvdata()
PATCH 2/8 net: ucc_geth: use platform_{get,set}_drvdata()
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, so we can directly pass a struct platform_device.
Signed-off-by Libo Chen <[email protected]>
--- drivers/net/ethernet/freescale/ucc_geth.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
drivers/net/ethernet/freescale/ucc_geth.c +1 -3
@@ -3911,14 +3911,12 @@ static int ucc_geth_probe(struct platform_device* ofdev)static int ucc_geth_remove (struct platform_device * ofdev) { -struct device *device = &ofdev->dev; -struct net_device *dev =dev_get_drvdata (device); +struct net_device *dev =platform_get_drvdata (ofdev);struct ucc_geth_private *ugeth =netdev_priv (dev);unregister_netdev (dev);free_netdev (dev);ucc_geth_memclean (ugeth); -dev_set_drvdata (device,NULL );return 0 ; }
Signature · 1 line
1.7.1
PATCH RESEND 2/8 net: ucc_geth: use platform_{get,set}_drvdata()
We can use the wrapper functions platform_{get,set}_drvdata() instead of dev_{get,set}_drvdata() with &ofdev->dev, it is convenient for user.
Also, unnecessary dev_set_drvdata() is removed, because the driver core clears the driver data to NULL after device_release or on probe failure.
Signed-off-by Libo Chen <[email protected]>
--- drivers/net/ethernet/freescale/ucc_geth.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
drivers/net/ethernet/freescale/ucc_geth.c +1 -3
@@ -3911,14 +3911,12 @@ static int ucc_geth_probe(struct platform_device* ofdev)static int ucc_geth_remove (struct platform_device * ofdev) { -struct device *device = &ofdev->dev; -struct net_device *dev =dev_get_drvdata (device); +struct net_device *dev =platform_get_drvdata (ofdev);struct ucc_geth_private *ugeth =netdev_priv (dev);unregister_netdev (dev);free_netdev (dev);ucc_geth_memclean (ugeth); -dev_set_drvdata (device,NULL );return 0 ; }
Signature · 1 line
1.7.1