Skip to contentSkip to conversation

[3.11] cpuset: fix the return value of cpuset_write_u64()

PATCH Applied Li Zefan 2 participants 2 messages Aug 13, 2013 cgroup

lore
Share & tools
lore

Li Zefan

author
#0 lore raw

PATCH 1/1 [3.11] cpuset: fix the return value of cpuset_write_u64()

Writing to this file always returns -ENODEV:

  # echo 1 > cpuset.memory_pressure_enabled
  -bash: echo: write error: No such device
Signed-off-by Li Zefan <[email protected]>
Cc <[email protected]> # 3.9+
---
 kernel/cpuset.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
kernel/cpuset.c +4 -2
index 1b9c315..c602ab8 100644
@@ -1607,11 +1607,13 @@ static int cpuset_write_u64(struct cgroup *cgrp, struct cftype *cft, u64 val)
 {
 	struct cpuset *cs = cgroup_cs(cgrp);
 	cpuset_filetype_t type = cft->private;
-	int retval = -ENODEV;
+	int retval = 0;
 
 	mutex_lock(&cpuset_mutex);
-	if (!is_cpuset_online(cs))
+	if (!is_cpuset_online(cs)) {
+		retval = -ENODEV;
 		goto out_unlock;
+	}
 
 	switch (type) {
 	case FILE_CPU_EXCLUSIVE:
Signature · 1 line
1.8.0.2
maintainer Applied
#1 lore raw
Quoted 7 lines · Li Zefan

Writing to this file always returns -ENODEV:

  # echo 1 > cpuset.memory_pressure_enabled
  -bash: echo: write error: No such device
Signed-off-by Li Zefan <[email protected]>
Cc <[email protected]> # 3.9+

Applied to cgroup/for-3.11-fixes. Thanks.

Signature · 1 line
tejun