Skip to contentSkip to conversation

s2disk broken (bisected) in 3.10.4

DISCUSSION Toralf Förster 2 participants 3 messages Aug 14, 2013 – Aug 15, 2013 X.25 stack

lore
Share & tools
lore
#0 lore raw

The following bisected commit

commit ea4c218f2c3e67f1bca8078ff1f80d7e0c2ab791

Author: Dave Jones <[email protected]>
Date:   Fri Jun 28 12:13:52 2013 -0400

x25: Fix broken locking in ioctl error paths.

[ Upstream commit 4ccb93ce7439b63c31bc7597bfffd13567fa483d ]

Two of the x25 ioctl cases have error paths that break out of the function without unlocking the socket, leading to this warning:

breaks s2disk at a 32 bit stable Gentoo Linux (booted from an external USB drive). Reverting that commit on top of 3.10.6 solved the issue.

After wakeup the cursor doesn't blink and the systems just hangs, magic sysrq works fortunately.

Signature · 3 lines
MfG/Sincerely
Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3
#1 lore raw
Quoted 16 lines · Toralf Förster

The following bisected commit

commit ea4c218f2c3e67f1bca8078ff1f80d7e0c2ab791

Author: Dave Jones <[email protected]>
Date:   Fri Jun 28 12:13:52 2013 -0400

x25: Fix broken locking in ioctl error paths.

[ Upstream commit 4ccb93ce7439b63c31bc7597bfffd13567fa483d ]

Two of the x25 ioctl cases have error paths that break out of the function without unlocking the socket, leading to this warning:

Quoted 4 lines

breaks s2disk at a 32 bit stable Gentoo Linux (booted from an external USB drive). Reverting that commit on top of 3.10.6 solved the issue.

After wakeup the cursor doesn't blink and the systems just hangs, magic sysrq works fortunately.

<sceptical hat on>

Are you actually using x25 ?

Dave

#2 lore raw
Quoted 1 line · Dave Jones

<sceptical hat on>

You're right - the issue happens erratically, I've to triple-check each bisect step ...

Signature · 3 lines
MfG/Sincerely
Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3