Skip to contentSkip to conversation

net: xilinx_emaclite: use platform_{get,set}_drvdata()

PATCH Superseded Libo Chen 2 participants 3 messages Aug 15, 2013 – Aug 16, 2013

Subsystems (2)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Libo Chen

author
#0 lore raw

PATCH v3 6/7 net: xilinx_emaclite: use platform_{get,set}_drvdata()

Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with &of_dev->dev, so we can directly pass a struct platform_device.

---
 drivers/net/ethernet/xilinx/xilinx_emaclite.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
drivers/net/ethernet/xilinx/xilinx_emaclite.c +1 -2
index fd4dbda..7c1ccbc 100644
@@ -1230,8 +1230,7 @@ error:
  */
 static int xemaclite_of_remove(struct platform_device *of_dev)
 {
-	struct device *dev = &of_dev->dev;
-	struct net_device *ndev = dev_get_drvdata(dev);
+	struct net_device *ndev = platform_get_drvdata(of_dev);
 
 	struct net_local *lp = netdev_priv(ndev);
 
Signature · 1 line
1.7.1
maintainer
#1 lore raw

From: Libo Chen <[email protected]>
Date: Thu, 15 Aug 2013 21:01:47 +0800

Quoted 5 lines

Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with &of_dev->dev, so we can directly pass a struct platform_device.

Why did you not CC: netdev on this patch?

author
#2 lore raw
Quoted 11 lines · David Miller

From: Libo Chen <[email protected]>
Date: Thu, 15 Aug 2013 21:01:47 +0800

Quoted 5 lines

Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with &of_dev->dev, so we can directly pass a struct platform_device.

Why did you not CC: netdev on this patch?

oh, my script doesn`t work well!

Quoted 1 line