Skip to contentSkip to conversation

x86/srat: use NUMA_NO_NODE

PATCH In review Jianguo Wu 2 participants 2 messages Aug 30, 2013

Subsystems (3)
Memory management x86 x86 MM
lore
Share & tools
lore

Jianguo Wu

author
#0 lore raw

PATCH 3/4 x86/srat: use NUMA_NO_NODE

setup_node() return NUMA_NO_NODE or valid node id(>=0), So use more appropriate "if (node == NUMA_NO_NODE)" instead of "if (node < 0)"

Signed-off-by Jianguo Wu <[email protected]>
---
 arch/x86/mm/srat.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
arch/x86/mm/srat.c +3 -3
index cdd0da9..97fea4e 100644
@@ -76,7 +76,7 @@ acpi_numa_x2apic_affinity_init(struct acpi_srat_x2apic_cpu_affinity *pa)
 		return;
 	}
 	node = setup_node(pxm);
-	if (node < 0) {
+	if (node == NUMA_NO_NODE) {
 		printk(KERN_ERR "SRAT: Too many proximity domains %x\n", pxm);
 		bad_srat();
 		return;

@@ -112,7 +112,7 @@ acpi_numa_processor_affinity_init(struct acpi_srat_cpu_affinity *pa)
 	if (acpi_srat_revision >= 2)
 		pxm |= *((unsigned int*)pa->proximity_domain_hi) << 8;
 	node = setup_node(pxm);
-	if (node < 0) {
+	if (node == NUMA_NO_NODE) {
 		printk(KERN_ERR "SRAT: Too many proximity domains %x\n", pxm);
 		bad_srat();
 		return;

@@ -164,7 +164,7 @@ acpi_numa_memory_affinity_init(struct acpi_srat_mem_affinity *ma)
 		pxm &= 0xff;
 
 	node = setup_node(pxm);
-	if (node < 0) {
+	if (node == NUMA_NO_NODE) {
 		printk(KERN_ERR "SRAT: Too many proximity domains.\n");
 		goto out_err_bad_srat;
 	}
Signature · 1 line
1.7.1
Acked-by on v1 3/4
#1 lore raw
Quoted 4 lines · Jianguo Wu

setup_node() return NUMA_NO_NODE or valid node id(>=0), So use more appropriate "if (node == NUMA_NO_NODE)" instead of "if (node < 0)"

Signed-off-by Jianguo Wu <[email protected]>
Acked-by David Rientjes <[email protected]>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>