media: usb: b2c2: Kconfig: add PCI dependancy to DVB_B2C2_FLEXCOP_USB
PATCH 1/1 media: usb: b2c2: Kconfig: add PCI dependancy to DVB_B2C2_FLEXCOP_USB
DVB_B2C2_FLEXCOP_USB need depend on PCI, or can not pass compiling with allmodconfig for h8300.
The related error:
drivers/media/usb/b2c2/flexcop-usb.c: In function 'flexcop_usb_transfer_exit':
drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function 'pci_free_consistent' [-Werror=implicit-function-declaration]
pci_free_consistent(NULL,
^
drivers/media/usb/b2c2/flexcop-usb.c: In function 'flexcop_usb_transfer_init':
drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function 'pci_alloc_consistent' [-Werror=implicit-function-declaration]
fc_usb->iso_buffer = pci_alloc_consistent(NULL,
^
drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
fc_usb->iso_buffer = pci_alloc_consistent(NULL,
^cc1: some warnings being treated as errors
--- drivers/media/usb/b2c2/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/media/usb/b2c2/Kconfig +1 -1
@@ -1,6 +1,6 @@ config DVB_B2C2_FLEXCOP_USB tristate "Technisat/B2C2 Air/Sky/Cable2PC USB" - depends on DVB_CORE && I2C + depends on DVB_CORE && I2C && PCI help Support for the Air/Sky/Cable2PC USB1.1 box (DVB/ATSC) by Technisat/B2C2,
Signature · 1 line
1.7.7.6
A message that is not in the archive (sent off-list or not yet received): 3939732.OJKiKvCJjt@dibcom294
Quoted 40 lines · Patrick Boettcher
Hi,
Quoted 33 lines · On Friday 30 August 2013 10:23:24 Chen Gang wrote:
DVB_B2C2_FLEXCOP_USBneed depend on PCI, or can not pass compiling withallmodconfig for h8300.
The related error:
drivers/media/usb/b2c2/flexcop-usb.c: In function'
flexcop_usb_transfer_exit':drivers/media/usb/b2c2/flexcop-usb.c:393:3:error: implicit declaration of function '
pci_free_consistent'[-Werror=implicit-function-declaration] pci_free_consistent(NULL,
[..]
config
DVB_B2C2_FLEXCOP_USBtristate "Technisat/B2C2 Air/Sky/Cable2PC USB"
- depends on
DVB_CORE&& I2C+ depends on
DVB_CORE&& I2C && PCIhelp
Quoted 9 lines
Quoted 3 lines
Support for the Air/Sky/Cable2PC USB1.1 box (DVB/ATSC) by
Technisat/B2C2,
Instead of selecting PCI we could/should use
usb_alloc_coherent()andusb_free_cohrerent(), shouldn't we?
Hmm... maybe it is a good idea, but I am just trying another ways.
Just now, I find that the module which calls pci*consistent() may not be pci dependent module (e.g. may depend on ISA or EISA instead of).
So "arch/h8300/include/asm/pci.h" has related issues, I am just fixing.
Maybe our case is not an issue, after "asm/pci.h" fixed (although for our case only, it can be improved, too, and if you are sure about it, please help improving it, thanks).
Quoted 6 lines
--
Patrick
Thanks.
Signature · 1 line
Chen Gang
Hi (sending again due to HTML-nonsense in Mail),
Quoted 18 lines · On Friday 30 August 2013 10:23:24 Chen Gang wrote:
DVB_B2C2_FLEXCOP_USBneed depend on PCI, or can not pass compiling with allmodconfig for h8300.The related error:
drivers/media/usb/b2c2/flexcop-usb.c: In function
'flexcop_usb_transfer_exit':drivers/media/usb/b2c2/flexcop-usb.c:393:3:
error: implicit declaration of function 'pci_free_consistent' [-Werror=implicit-function-declaration] pci_free_consistent(NULL,[..]
config
DVB_B2C2_FLEXCOP_USBdrivers/media/usb/b2c2/Kconfig +1
-1tristate "Technisat/B2C2 Air/Sky/Cable2PC USB" - depends on DVB_CORE && I2C + depends on DVB_CORE && I2C && PCI help Support for the Air/Sky/Cable2PC USB1.1 box (DVB/ATSC) by
Quoted 1 line
Technisat/B2C2,
Instead of selecting PCI we could/should use usb_alloc_coherent() and usb_free_cohrerent(), shouldn't we?
--
Patrick