Skip to contentSkip to conversation

mtd: bcm47xxsflash: the argument to kfree should not be the address of a structure field

PATCH In review Duan Jiong 2 participants 2 messages Sep 5, 2013 Memory technology devices (MTD)

lore
Share & tools
lore

Duan Jiong

author
#0 lore raw

PATCH 1/1 mtd: bcm47xxsflash: the argument to kfree should not be the address of a structure field

From: Duan Jiong <[email protected]>

---
 drivers/mtd/devices/bcm47xxsflash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/devices/bcm47xxsflash.c +1 -1
index 18e7761..9b8aaf3 100644
@@ -87,7 +87,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device *pdev)
 	return 0;
 
 err_dev_reg:
-	kfree(&b47s->mtd);
+	kfree(b47s);
 out:
 	return err;
 }
Signature · 1 line
1.8.3.1
#1 lore raw

drivers/mtd/devices/bcm47xxsflash.c static int bcm47xxsflash_bcma_probe(struct platform_device *pdev) · line 93

Quoted 6 lines · Duan Jiong

err_dev_reg:

drivers/mtd/devices/bcm47xxsflash.c +1 -1
-	kfree(&b47s->mtd);
+	kfree(b47s);
 out:
 	return err;
 }

Thanks, but this is already fixed in linux-next, and will be going to Linus very shortly:

http://git.infradead.org/linux-mtd.git/commitdiff/d2b1bd1422

Signature · 2 lines
David Woodhouse                            Open Source Technology Centre
[email protected]                              Intel Corporation