mm/thp: fix stale comments of transparent_hugepage_flags

PATCH Superseded Jianguo Wu 2 participants 4 messages Sep 5, 2013 1 message not in the archive

Subsystems (2)

Memory management THP

lore

Share & tools

lore

Jianguo Wu

author

2013-09-05 07:58 UTC #0 lore raw

PATCH v2 1/1 mm/thp: fix stale comments of transparent_hugepage_flags

Changelog:
*v1 -> v2: also update the stale comments about default transparent
hugepage support pointed by Wanpeng Li.

Since commit 13ece886d9(thp: transparent hugepage config choice), transparent hugepage support is disabled by default, and TRANSPARENT_HUGEPAGE_ALWAYS is configured when TRANSPARENT_HUGEPAGE=y.

And since commit d39d33c332(thp: enable direct defrag), defrag is enable for all transparent hugepage page faults by default, not only in MADV_HUGEPAGE regions.

Signed-off-by Jianguo Wu <[email protected]>

---
 mm/huge_memory.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

mm/huge_memory.c +6 -6

index a92012a..0e42a70 100644
@@ -26,12 +26,12 @@
 #include <asm/pgalloc.h>
 #include "internal.h"
 
-/*
- * By default transparent hugepage support is enabled for all mappings
- * and khugepaged scans all mappings. Defrag is only invoked by
- * khugepaged hugepage allocations and by page faults inside
- * MADV_HUGEPAGE regions to avoid the risk of slowing down short lived
- * allocations.
+/* By default transparent hugepage support is disabled in order that avoid
+ * to risk increase the memory footprint of applications without a guaranteed
+ * benefit. When transparent hugepage support is enabled, is for all mappings,
+ * and khugepaged scans all mappings.
+ * Defrag is invoked by khugepaged hugepage allocations and by page faults
+ * for all hugepage allocations.
  */
 unsigned long transparent_hugepage_flags __read_mostly =
 #ifdef CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS

Signature · 8 lines

1.7.1


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Wanpeng Li

Reviewed-by on v2 1/1

2013-09-05 08:09 UTC #1 lore raw

Quoted 4 lines · Jianguo Wu

Changelog:
*v1 -> v2: also update the stale comments about default transparent hugepage support pointed by Wanpeng Li.

Quoted 8 lines

Since commit 13ece886d9(thp: transparent hugepage config choice), transparent hugepage support is disabled by default, and TRANSPARENT_HUGEPAGE_ALWAYS is configured when TRANSPARENT_HUGEPAGE=y.
And since commit d39d33c332(thp: enable direct defrag), defrag is enable for all transparent hugepage page faults by default, not only in MADV_HUGEPAGE regions.

Reviewed-by Wanpeng Li <[email protected]>

Quoted 26 lines

Signed-off-by Jianguo Wu <[email protected]>

---
mm/huge_memory.c | 12 ++++++------

1 files changed, 6 insertions(+), 6 deletions(-)

mm/huge_memory.c +6 -6

index a92012a..0e42a70 100644
@@ -26,12 +26,12 @@
 #include <asm/pgalloc.h>
 #include "internal.h"
 
-/*
- * By default transparent hugepage support is enabled for all mappings
- * and khugepaged scans all mappings. Defrag is only invoked by
- * khugepaged hugepage allocations and by page faults inside
- * MADV_HUGEPAGE regions to avoid the risk of slowing down short lived
- * allocations.
+/* By default transparent hugepage support is disabled in order that avoid
+ * to risk increase the memory footprint of applications without a guaranteed
+ * benefit. When transparent hugepage support is enabled, is for all mappings,
+ * and khugepaged scans all mappings.
+ * Defrag is invoked by khugepaged hugepage allocations and by page faults
+ * for all hugepage allocations.
 */

Quoted 5 lines

unsigned long transparent_hugepage_flags __read_mostly = #ifdef CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS
Signature · 1 line
1.7.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Wanpeng Li

Reviewed-by on v2 1/1

2013-09-05 08:09 UTC #2 lore raw

In reply to Jianguo Wu

Quoted 4 lines · Jianguo Wu

Changelog:
*v1 -> v2: also update the stale comments about default transparent hugepage support pointed by Wanpeng Li.

Quoted 8 lines

Since commit 13ece886d9(thp: transparent hugepage config choice), transparent hugepage support is disabled by default, and TRANSPARENT_HUGEPAGE_ALWAYS is configured when TRANSPARENT_HUGEPAGE=y.
And since commit d39d33c332(thp: enable direct defrag), defrag is enable for all transparent hugepage page faults by default, not only in MADV_HUGEPAGE regions.

Reviewed-by Wanpeng Li <[email protected]>

Quoted 26 lines

Signed-off-by Jianguo Wu <[email protected]>

---
mm/huge_memory.c | 12 ++++++------

1 files changed, 6 insertions(+), 6 deletions(-)

mm/huge_memory.c +6 -6

index a92012a..0e42a70 100644
@@ -26,12 +26,12 @@
 #include <asm/pgalloc.h>
 #include "internal.h"
 
-/*
- * By default transparent hugepage support is enabled for all mappings
- * and khugepaged scans all mappings. Defrag is only invoked by
- * khugepaged hugepage allocations and by page faults inside
- * MADV_HUGEPAGE regions to avoid the risk of slowing down short lived
- * allocations.
+/* By default transparent hugepage support is disabled in order that avoid
+ * to risk increase the memory footprint of applications without a guaranteed
+ * benefit. When transparent hugepage support is enabled, is for all mappings,
+ * and khugepaged scans all mappings.
+ * Defrag is invoked by khugepaged hugepage allocations and by page faults
+ * for all hugepage allocations.
 */

Quoted 5 lines

unsigned long transparent_hugepage_flags __read_mostly = #ifdef CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS
Signature · 1 line
1.7.1

Jianguo Wu

author

2013-09-05 08:44 UTC #4 lore raw

In reply to a message not in the archive

Hi Wanpeng,
Thanks for your review, but this patch has minor format problem, please see below. Please review the resend one, thanks.

Thanks,
Jianguo Wu

Quoted 29 lines · Wanpeng Li

Quoted 4 lines · Jianguo Wu
Changelog:
*v1 -> v2: also update the stale comments about default transparent hugepage support pointed by Wanpeng Li.
Quoted 8 lines
Since commit 13ece886d9(thp: transparent hugepage config choice), transparent hugepage support is disabled by default, and TRANSPARENT_HUGEPAGE_ALWAYS is configured when TRANSPARENT_HUGEPAGE=y.
And since commit d39d33c332(thp: enable direct defrag), defrag is enable for all transparent hugepage page faults by default, not only in MADV_HUGEPAGE regions.
Reviewed-by Wanpeng Li <[email protected]>
Quoted 13 lines
Signed-off-by Jianguo Wu <[email protected]>
---
mm/huge_memory.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
mm/huge_memory.c +0 -0
index a92012a..0e42a70 100644
@@ -26,12 +26,12 @@
 #include <asm/pgalloc.h>
 #include "internal.h"
 

Quoted 7 lines

mm/huge_memory.c line 29

Quoted 7 lines

mm/huge_memory.c +1 -6

-/*
- * By default transparent hugepage support is enabled for all mappings
- * and khugepaged scans all mappings. Defrag is only invoked by
- * khugepaged hugepage allocations and by page faults inside
- * MADV_HUGEPAGE regions to avoid the risk of slowing down short lived
- * allocations.
+/* By default transparent hugepage support is disabled in order that avoid

Should be:
+/*
+ * By default transparent hugepage support is disabled in order that avoid

Please review the resend one.

Thanks.

Quoted 12 lines

Quoted 11 lines
mm/huge_memory.c +5 -0
+ * to risk increase the memory footprint of applications without a guaranteed
+ * benefit. When transparent hugepage support is enabled, is for all mappings,
+ * and khugepaged scans all mappings.
+ * Defrag is invoked by khugepaged hugepage allocations and by page faults
+ * for all hugepage allocations.
 */
unsigned long transparent_hugepage_flags __read_mostly = #ifdef CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS
Signature · 1 line
1.7.1

Quoted 7 lines

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>