Skip to contentSkip to conversation

powerpc allmodconfig build broken due to commit 15863ff3b (powerpc: Make chip-id information available to userspace)

DISCUSSION Guenter Roeck 4 participants 6 messages Sep 9, 2013 – Sep 11, 2013

lore
Share & tools
lore
#0 lore raw

Hi all,

powerpc allmodconfig build on the latest upstream kernel results in:

ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined!

This is due to commit 15863ff3b (powerpc: Make chip-id information available to userspace). Not surprising, as cpu_to_chip_id() is not exported.

Reverting this commit fixes the problem. Any good idea how to fix it for real ?

Guenter

#1 lore raw
Quoted 9 lines · Guenter Roeck

Hi all,

powerpc allmodconfig build on the latest upstream kernel results in:

ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined!

This is due to commit 15863ff3b (powerpc: Make chip-id information available to userspace). Not surprising, as cpu_to_chip_id() is not exported.

Apart from the above error, I have a concern on the patch, purely based on the commit message. (to be honest, I am not familiar with the ppc architecture)

Commit message of 15863ff3b has the following text.

******************
So far "/sys/devices/system/cpu/cpuX/topology/physical_package_id" was always default (-1) on ppc64 architecture.

Now, some systems have an ibm,chip-id property in the cpu nodes in the device tree. On these systems, we now use this information to display physical_package_id
******************

Shouldn't the new definition of "topology_physical_package_id" apply only to those systems supporting ibm,chip-id property?

Quoted 8 lines

Reverting this commit fixes the problem. Any good idea how to fix it for real ?

Guenter

Signature · 4 lines
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
#2 lore raw
Quoted 19 lines · Asai Thambi S P
Quoted 9 lines · Guenter Roeck

Hi all,

powerpc allmodconfig build on the latest upstream kernel results in:

ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined!

This is due to commit 15863ff3b (powerpc: Make chip-id information available to userspace). Not surprising, as cpu_to_chip_id() is not exported.

Apart from the above error, I have a concern on the patch, purely based on the commit message. (to be honest, I am not familiar with the ppc architecture)

Commit message of 15863ff3b has the following text.

******************
So far "/sys/devices/system/cpu/cpuX/topology/physical_package_id" was always default (-1) on ppc64 architecture.

Quoted 7 lines

Now, some systems have an ibm,chip-id property in the cpu nodes in the device tree. On these systems, we now use this information to display physical_package_id
******************

Shouldn't the new definition of "topology_physical_package_id" apply only to those systems supporting ibm,chip-id property?

Looking into the code, I think that is what it does. For other platforms (ie if there is no ibm,chip-id property) it still returns -1.

Question for the fix is what path to take to fix the problem. Exporting cpu_to_chip_id() might be the easiest solution. Other platforms export the respective data, so it should not be a problem.

I might submit a patch and see where it goes.

Guenter

Quoted 12 lines
Quoted 9 lines

Reverting this commit fixes the problem. Any good idea how to fix it for real ?

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#3 lore raw
In reply to Asai Thambi S P
Quoted 20 lines · Asai Thambi S P
Quoted 10 lines · Guenter Roeck

Hi all,

powerpc allmodconfig build on the latest upstream kernel results in:

ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined!

This is due to commit 15863ff3b (powerpc: Make chip-id information available to userspace).
Not surprising, as cpu_to_chip_id() is not exported.

Apart from the above error, I have a concern on the patch, purely based on the commit message. (to be honest, I am not familiar with the ppc architecture)

Commit message of 15863ff3b has the following text.

******************
So far "/sys/devices/system/cpu/cpuX/topology/physical_package_id" was always default (-1) on ppc64 architecture.

Quoted 6 lines

Now, some systems have an ibm,chip-id property in the cpu nodes in the device tree. On these systems, we now use this information to display physical_package_id
******************

Shouldn't the new definition of "topology_physical_package_id" apply only to those systems supporting ibm,chip-id property?

There should be no negative side effect (appart from the missing EXPORT_SYMBOL of course). If the property is not found in the device-tree, the new function returns -1, so it should work fine on all systems.

Cheers,
Ben.

Quoted 11 lines
Quoted 11 lines

Reverting this commit fixes the problem. Any good idea how to fix it for real ?

Guenter

Signature · 5 lines
To unsubscribe from this list: send the line "unsubscribe 
linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
#4 lore raw
Quoted 26 lines · Benjamin Herrenschmidt
Quoted 25 lines · Asai Thambi S P
Quoted 10 lines · Guenter Roeck

Hi all,

powerpc allmodconfig build on the latest upstream kernel results in:

ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined!

This is due to commit 15863ff3b (powerpc: Make chip-id information available to userspace).
Not surprising, as cpu_to_chip_id() is not exported.

Apart from the above error, I have a concern on the patch, purely based on the commit message. (to be honest, I am not familiar with the ppc architecture)

Commit message of 15863ff3b has the following text.

******************
So far "/sys/devices/system/cpu/cpuX/topology/physical_package_id" was always default (-1) on ppc64 architecture.

Now, some systems have an ibm,chip-id property in the cpu nodes in the device tree. On these systems, we now use this information to display physical_package_id
******************

Quoted 7 lines
Quoted 1 line

Shouldn't the new definition of "topology_physical_package_id" apply only to those systems supporting ibm,chip-id property?

There should be no negative side effect (appart from the missing EXPORT_SYMBOL of course). If the property is not found in the device-tree, the new function returns -1, so it should work fine on all systems.

Good. I submitted a patch doing just that yesterday or so. Hope you'll accept it ;).

Thanks,
Guenter

#5 lore raw
Quoted 5 lines · Guenter Roeck
Quoted 4 lines · Benjamin Herrenschmidt
Quoted 3 lines · Asai Thambi S P
Quoted 2 lines · Guenter Roeck

Hi all,

Guenter, Ben,

Sorry for the inconvenience. I never realized my patch could break somewhere :-(

Thanks you very much for identifying and fixing this issue. Other patch looks good to me.

-Vasant

Quoted 39 lines
Quoted 22 lines
Quoted 22 lines
Quoted 8 lines

powerpc allmodconfig build on the latest upstream kernel results in:

ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined!

This is due to commit 15863ff3b (powerpc: Make chip-id information available to userspace).
Not surprising, as cpu_to_chip_id() is not exported.

Apart from the above error, I have a concern on the patch, purely based on the commit message. (to be honest, I am not familiar with the ppc architecture)

Commit message of 15863ff3b has the following text.

******************
So far "/sys/devices/system/cpu/cpuX/topology/physical_package_id" was always default (-1) on ppc64 architecture.

Now, some systems have an ibm,chip-id property in the cpu nodes in the device tree. On these systems, we now use this information to display physical_package_id
******************

Quoted 7 lines
Quoted 1 line

Shouldn't the new definition of "topology_physical_package_id" apply only to those systems supporting ibm,chip-id property?

There should be no negative side effect (appart from the missing EXPORT_SYMBOL of course). If the property is not found in the device-tree, the new function returns -1, so it should work fine on all systems.

Good. I submitted a patch doing just that yesterday or so. Hope you'll accept it ;).

Thanks,
Guenter
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev