Skip to contentSkip to conversation

mm/hotplug: rename the function is_memblock_offlined_cb()

PATCH In review Xishi Qiu 2 participants 3 messages Sep 9, 2013

Subsystems (2)
Memory management Memory hot(un)plug
lore
Share & tools
lore

Xishi Qiu

author
#0 lore raw

PATCH 1/2 mm/hotplug: rename the function is_memblock_offlined_cb()

Function is_memblock_offlined() return 1 means memory block is offlined, but is_memblock_offlined_cb() return 1 means memory block is not offlined, this will confuse somebody, so rename the function.

Signed-off-by Xishi Qiu <[email protected]>
Acked-by Yasuaki Ishimatsu <[email protected]>
---
 mm/memory_hotplug.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
mm/memory_hotplug.c +2 -2
index ca1dd3a..85f80b7 100644
@@ -1657,7 +1657,7 @@ int walk_memory_range(unsigned long start_pfn, unsigned long end_pfn,
 }
 
 #ifdef CONFIG_MEMORY_HOTREMOVE
-static int is_memblock_offlined_cb(struct memory_block *mem, void *arg)
+static int check_memblock_offlined_cb(struct memory_block *mem, void *arg)
 {
 	int ret = !is_memblock_offlined(mem);
 

@@ -1794,7 +1794,7 @@ void __ref remove_memory(int nid, u64 start, u64 size)
 	 * if this is not the case.
 	 */
 	ret = walk_memory_range(PFN_DOWN(start), PFN_UP(start + size - 1), NULL,
-				is_memblock_offlined_cb);
+				check_memblock_offlined_cb);
 	if (ret) {
 		unlock_memory_hotplug();
 		BUG();
Signature · 8 lines
1.7.1


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
#1 lore raw

[CCing Kosaki since he maintains mm/memory_hotplug.c]

Quoted 8 lines · Xishi Qiu

Function is_memblock_offlined() return 1 means memory block is offlined, but is_memblock_offlined_cb() return 1 means memory block is not offlined, this will confuse somebody, so rename the function.

Signed-off-by Xishi Qiu <[email protected]>
Acked-by Yasuaki Ishimatsu <[email protected]>

---

I have not acked your previous patch yet. But this patch seems good to me. So I acked the patch.

Thanks,
Yasuaki Ishimatsu

Quoted 18 lines
  mm/memory_hotplug.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
mm/memory_hotplug.c +1 -1
index ca1dd3a..85f80b7 100644
@@ -1657,7 +1657,7 @@ int walk_memory_range(unsigned long start_pfn, unsigned long end_pfn,
  }
 
  #ifdef CONFIG_MEMORY_HOTREMOVE
-static int is_memblock_offlined_cb(struct memory_block *mem, void *arg)
+static int check_memblock_offlined_cb(struct memory_block *mem, void *arg)
  {
  	int ret = !is_memblock_offlined(mem);

mm/memory_hotplug.c void __ref remove_memory(int nid, u64 start, u64 size) · line 1800

Quoted 8 lines
mm/memory_hotplug.c +1 -1
@@ -1794,7 +1794,7 @@ void __ref remove_memory(int nid, u64 start, u64 size)
  	 * if this is not the case.
  	 */
  	ret = walk_memory_range(PFN_DOWN(start), PFN_UP(start + size - 1), NULL,
-				is_memblock_offlined_cb);
+				check_memblock_offlined_cb);
  	if (ret) {
  		unlock_memory_hotplug();
  		BUG();

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

author
#2 lore raw
Quoted 8 lines · Yasuaki Ishimatsu

[CCing Kosaki since he maintains mm/memory_hotplug.c]

Quoted 4 lines · Xishi Qiu

Function is_memblock_offlined() return 1 means memory block is offlined, but is_memblock_offlined_cb() return 1 means memory block is not offlined, this will confuse somebody, so rename the function.

Quoted 7 lines
Quoted 3 lines
Signed-off-by Xishi Qiu <[email protected]>
Acked-by Yasuaki Ishimatsu <[email protected]>

---

I have not acked your previous patch yet. But this patch seems good to me. So I acked the patch.

Sorry, I mistakenly thought "seems good to me" was the same as acked, I'll pay attention next time.

Thanks,
Xishi Qiu

Quoted 33 lines

Thanks,
Yasuaki Ishimatsu

Quoted 26 lines
  mm/memory_hotplug.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
mm/memory_hotplug.c +2 -2
index ca1dd3a..85f80b7 100644
@@ -1657,7 +1657,7 @@ int walk_memory_range(unsigned long start_pfn, unsigned long end_pfn,
  }
 
  #ifdef CONFIG_MEMORY_HOTREMOVE
-static int is_memblock_offlined_cb(struct memory_block *mem, void *arg)
+static int check_memblock_offlined_cb(struct memory_block *mem, void *arg)
  {
      int ret = !is_memblock_offlined(mem);
 

@@ -1794,7 +1794,7 @@ void __ref remove_memory(int nid, u64 start, u64 size)
       * if this is not the case.
       */
      ret = walk_memory_range(PFN_DOWN(start), PFN_UP(start + size - 1), NULL,
-                is_memblock_offlined_cb);
+                check_memblock_offlined_cb);
      if (ret) {
          unlock_memory_hotplug();
          BUG();