Skip to contentSkip to conversation

BCM70010 (crystalhd) Linux Driver

DISCUSSION Peter Paul 6 participants 11 messages Dec 30, 2009 – Jan 3, 2010 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
Quoted 6 lines · Peter Paul

Broadcom has just released a linux driver for their BCM70012 and BCM70015 Crystal HD High Definition video decoders under the GPLv2 licence. [1] Maybe you want to have a look at them.

[1] http://www.broadcom.com/support/crystal_hd/

From quick inspection kernel part looks much better than most vendor-provided

drivers. It needs some cleanups and bugfixes, for example error handling in device probe function doesn't look right to me, driver can't handle more than one device as far as I can see (I don't know is it really needed though), etc. But anyway this driver definitely deserves putting into staging.

#2 lore raw
Quoted 11 lines · Andrey Panin
Quoted 6 lines · Peter Paul

Broadcom has just released a linux driver for their BCM70012 and BCM70015 Crystal HD High Definition video decoders under the GPLv2 licence. [1] Maybe you want to have a look at them.

[1] http://www.broadcom.com/support/crystal_hd/

From quick inspection kernel part looks much better than most vendor-provided

drivers. It needs some cleanups and bugfixes, for example error handling in device probe function doesn't look right to me, driver can't handle more than one device as far as I can see (I don't know is it really needed though), etc. But anyway this driver definitely deserves putting into staging.

I'm glad to do so if someone wants to help work on it there and shephard it into the main kernel tree.

thanks,

greg k-h

#4 lore raw
In reply to a message not in the archive
Quoted 7 lines · Manu Abraham

Hi Greg,

Quoted 2 lines

I'm glad to do so if someone wants to help work on it there and shephard it into the main kernel tree.

Please find the initial round of cleaned up patches for staging, applied against linux-next.

Did you really author this driver? If so, that's fine, just checking. If not, please put the correct authorship "From:" in the patch.

Also, please break up patches to be sent one-per-email so they can be properly applied, and also only have them do one thing (your 4th patch fixed up coding style issues and added the driver to the build.)

Also, can you add a TODO file to the driver directory stating what is needed to be done, and who to contact about it?

thanks,

greg k-h

#5 lore raw

Hi Greg,

Quoted 11 lines · Greg KH
Quoted 7 lines · Manu Abraham

Hi Greg,

Quoted 2 lines

I'm glad to do so if someone wants to help work on it there and shephard it into the main kernel tree.

Please find the initial round of cleaned up patches for staging, applied against linux-next.

Did you really author this driver?  If so, that's fine, just checking. If not, please put the correct authorship "From:" in the patch.

I am not the author of the driver. I just picked it up and cleaned it up for Coding style changes for it to be included.

Quoted 3 lines

Also, please break up patches to be sent one-per-email so they can be properly applied, and also only have them do one thing (your 4th patch fixed up coding style issues and added the driver to the build.)

Okay, I will resend them.

Quoted 2 lines

Also, can you add a TODO file to the driver directory stating what is needed to be done, and who to contact about it?

I will test the device over the coming week and add in a TODO after that.

Thanks,
Manu

#6 lore raw
Quoted 7 lines · Manu Abraham
Quoted 6 lines · Greg KH
Quoted 5 lines · Manu Abraham

Hi Greg,

Quoted 2 lines

I'm glad to do so if someone wants to help work on it there and shephard it into the main kernel tree.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Please find the initial round of cleaned up patches for staging, applied against linux-next.

Did you really author this driver?  If so, that's fine, just checking. If not, please put the correct authorship "From:" in the patch.

I am not the author of the driver. I just picked it up and cleaned it up for Coding style changes for it to be included.

Can we try to figure out who the author is and please credit them?

Quoted 10 lines
Quoted 3 lines

Also, please break up patches to be sent one-per-email so they can be properly applied, and also only have them do one thing (your 4th patch fixed up coding style issues and added the driver to the build.)

Okay, I will resend them.

Quoted 2 lines

Also, can you add a TODO file to the driver directory stating what is needed to be done, and who to contact about it?

I will test the device over the coming week and add in a TODO after that.

I need a TODO before I can accept the patches, sorry.

thanks,

greg k-h

#7 lore raw
Quoted 11 lines · Greg KH
Quoted 10 lines · Manu Abraham
Quoted 9 lines · Greg KH
Quoted 7 lines · Manu Abraham

Hi Greg,

Quoted 2 lines

I'm glad to do so if someone wants to help work on it there and shephard it into the main kernel tree.

Please find the initial round of cleaned up patches for staging, applied against linux-next.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

Did you really author this driver?  If so, that's fine, just checking. If not, please put the correct authorship "From:" in the patch.

I am not the author of the driver. I just picked it up and cleaned it up for Coding style changes for it to be included.

Can we try to figure out who the author is and please credit them?

Module author has 2 people on it, added them, hope it works.

Quoted 4 lines
Quoted 4 lines
Quoted 3 lines

Also, please break up patches to be sent one-per-email so they can be properly applied, and also only have them do one thing (your 4th patch fixed up coding style issues and added the driver to the build.)

Quoted 8 lines
Quoted 6 lines

Okay, I will resend them.

Quoted 2 lines

Also, can you add a TODO file to the driver directory stating what is needed to be done, and who to contact about it?

I will test the device over the coming week and add in a TODO after that.

I need a TODO before I can accept the patches, sorry.

Ok will add in an initial TODO what i can see atm.

Regards,
Manu

#8 lore raw
In reply to Manu Abraham
Quoted 9 lines · Manu Abraham

Hi Greg,

Quoted 6 lines · Greg KH
Quoted 5 lines · Manu Abraham

Hi Greg,

Quoted 2 lines

I'm glad to do so if someone wants to help work on it there and shephard it into the main kernel tree.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Please find the initial round of cleaned up patches for staging, applied against linux-next.

Did you really author this driver?  If so, that's fine, just checking. If not, please put the correct authorship "From:" in the patch.

I am not the author of the driver. I just picked it up and cleaned it up for Coding style changes for it to be included.

I'm not against this submission, but would it be better to wait until Monday when the Broadcom authors are back as see if they want to submit their own driver? That way changes would end up back in their internal VCS.

I'd like to see a real datasheet for this chip, the public one is nothing but a marketing blurb.

Quoted 20 lines
Quoted 4 lines

Also, please break up patches to be sent one-per-email so they can be properly applied, and also only have them do one thing (your 4th patch fixed up coding style issues and added the driver to the build.)

Okay, I will resend them.

Quoted 2 lines

Also, can you add a TODO file to the driver directory stating what is needed to be done, and who to contact about it?

I will test the device over the coming week and add in a TODO after that.

Thanks,
Manu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Signature · 2 lines
Jon Smirl
[email protected]
#9 lore raw
Quoted 16 lines · Jon Smirl
Quoted 15 lines · Manu Abraham

Hi Greg,

Quoted 11 lines · Greg KH
Quoted 7 lines · Manu Abraham

Hi Greg,

Quoted 2 lines

I'm glad to do so if someone wants to help work on it there and shephard it into the main kernel tree.

Please find the initial round of cleaned up patches for staging, applied against linux-next.

Did you really author this driver?  If so, that's fine, just checking. If not, please put the correct authorship "From:" in the patch.

Quoted 7 lines
Quoted 2 lines

I am not the author of the driver. I just picked it up and cleaned it up for Coding style changes for it to be included.

I'm not against this submission, but would it be better to wait until Monday when the Broadcom authors are back as see if they want to submit their own driver? That way changes would end up back in their internal VCS.

Sure, of course,

Quoted 2 lines

I'd like to see a real datasheet for this chip, the public one is nothing but a marketing blurb.

You mean a user manual with a description of the registers, don't you ? Decoder datasheets from whichever manufacturer rarely come into public. Even with NDA's it is quite hard to get hold of a "proper one"

Regards,
Manu

#10 lore raw
In reply to Jon Smirl
Quoted 16 lines · Jon Smirl
Quoted 15 lines · Manu Abraham

Hi Greg,

Quoted 11 lines · Greg KH
Quoted 7 lines · Manu Abraham

Hi Greg,

Quoted 2 lines

I'm glad to do so if someone wants to help work on it there and shephard it into the main kernel tree.

Please find the initial round of cleaned up patches for staging, applied against linux-next.

Did you really author this driver?  If so, that's fine, just checking. If not, please put the correct authorship "From:" in the patch.

Quoted 7 lines
Quoted 2 lines

I am not the author of the driver. I just picked it up and cleaned it up for Coding style changes for it to be included.

I'm not against this submission, but would it be better to wait until Monday when the Broadcom authors are back as see if they want to submit their own driver? That way changes would end up back in their internal VCS.

Yes, please hold off a bit on this, I've actually been working on this driver with Scott and Naren (cc'd) for several months now (which is part of why it doesn't look so much like a lot of typical vendor code ;), and was planning to handle the submission on Naren and Broadcom's behalf. Just didn't expect someone else to hop on it this quickly. Was planning to get a git tree up on git.kernel.org over the weekend for both the driver and the lib, start prepping patches for review, etc., but family time and home improvement projects have taken precedence the past few days (not to mention a few other driver projects that sucked up time earlier in the break, *cough* IR).

Signature · 2 lines
Jarod Wilson
[email protected]
#11 lore raw
Quoted 5 lines · Jarod Wilson
Quoted 4 lines

I'm not against this submission, but would it be better to wait until Monday when the Broadcom authors are back as see if they want to submit their own driver? That way changes would end up back in their internal VCS.

Quoted 10 lines

Yes, please hold off a bit on this, I've actually been working on this driver with Scott and Naren (cc'd) for several months now (which is part of why it doesn't look so much like a lot of typical vendor code ;), and was planning to handle the submission on Naren and Broadcom's behalf. Just didn't expect someone else to hop on it this quickly. Was planning to get a git tree up on git.kernel.org over the weekend for both the driver and the lib, start prepping patches for review, etc., but family time and home improvement projects have taken precedence the past few days (not to mention a few other driver projects that sucked up time earlier in the break, *cough* IR).

Ok, I'll ignore the patches from Manu for now, but please, do not create a git tree, just send me what you have right now, as obviously some people find it useful. Then, everyone can work on it together in the main kernel.org tree, like the rest of kernel development is done.

If you have any questions about how to do this, please let me know.

thanks,

greg k-h