ibdiag_sa.c: Output attribute ID in hex rather than decimal

PATCH Applied Hal Rosenstock 2 participants 2 messages Sep 16, 2013 – Sep 22, 2013 1 message not in the archive InfiniBand

lore

Share & tools

lore

Hal Rosenstock

author

2013-09-16 14:19 UTC #0 lore raw

PATCH 1/1 ibdiag_sa.c: Output attribute ID in hex rather than decimal

so that it's easier to correlate to IBA spec

For example:
saquery PKTR 20/1/0 --smkey 1
ibwarn: sa_query: umad_send failed: attr 51: Bad file description

0x33 would be easier than 51 as no conversion is required to look it up in IBA spec.

Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>

---

src/ibdiag_sa.c +1 -1

index 7a5014c..018a428 100644
@@ -112,7 +112,7 @@ int sa_query(struct sa_handle * h, uint8_t method,
 
 	ret = umad_send(h->fd, h->agent, umad, len, ibd_timeout, 0);
 	if (ret < 0) {
-		IBWARN("umad_send failed: attr %u: %s\n",
+		IBWARN("umad_send failed: attr 0x%x: %s\n",
 			attr, strerror(errno));
 		free(umad);
 		return (-ret);

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 5237138E.9060705-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org

Weiny, Ira

Applied

2013-09-22 21:34 UTC #2 lore raw

Quoted 9 lines

-----Original Message-----
From: Hal Rosenstock [mailto:[email protected]]
Sent: Monday, September 16, 2013 7:20 AM
Subject: [PATCH infiniband-diags] ibdiag_sa.c: Output attribute ID in hex rather than decimal
so that it's easier to correlate to IBA spec

Quoted 8 lines

For example:
saquery PKTR 20/1/0 --smkey 1
ibwarn: sa_query: umad_send failed: attr 51: Bad file description
0x33 would be easier than 51 as no conversion is required to look it up in IBA spec.
Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>

Thanks, applied,
Ira

src/ibdiag_sa.c int sa_query(struct sa_handle * h, uint8_t method, · line 118

Quoted 13 lines

---

src/ibdiag_sa.c +1 -1

@@ -112,7 +112,7 @@ int sa_query(struct sa_handle * h, uint8_t method,
 
 	ret = umad_send(h->fd, h->agent, umad, len, ibd_timeout, 0);
 	if (ret < 0) {
-		IBWARN("umad_send failed: attr %u: %s\n",
+		IBWARN("umad_send failed: attr 0x%x: %s\n",
 			attr, strerror(errno));
 		free(umad);
 		return (-ret);

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html