Skip to contentSkip to conversation

clocksource: fix comment for __clocksource_updatefreq_scale

PATCH Superseded Xie XiuQi 2 participants 3 messages Sep 17, 2013 – Sep 18, 2013 Timekeeping, clocksource core, NTP, alarmtimer

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Xie XiuQi

author
#0 lore raw

PATCH 1/1 clocksource: fix comment for __clocksource_updatefreq_scale

The functions clocksource_updatefreq_hz() and clocksource_updatefreq_khz() do not exist, The proper ones are __clocksource_updatefreq_hz() and __clocksource_updatefreq_khz().

---
 kernel/time/clocksource.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
kernel/time/clocksource.c +2 -1
index 50a8736..d2f6ddc 100644
@@ -714,7 +714,8 @@ static void clocksource_enqueue(struct clocksource *cs)
  * This should only be called from the clocksource->enable() method.
  *
  * This *SHOULD NOT* be called directly! Please use the
- * clocksource_updatefreq_hz() or clocksource_updatefreq_khz helper functions.
+ * __clocksource_updatefreq_hz() or __clocksource_updatefreq_khz helper
+ * functions.
  */
 void __clocksource_updatefreq_scale(struct clocksource *cs, u32 scale, u32 freq)
 {
Signature · 1 line
1.8.2.1
#1 lore raw
Quoted 3 lines · Xie XiuQi

The functions clocksource_updatefreq_hz() and clocksource_updatefreq_khz() do not exist, The proper ones are __clocksource_updatefreq_hz() and __clocksource_updatefreq_khz().

I'd rather rename the functions and the few call sites because the underscores are completely meaningless.

Thanks,

tglx

Quoted 23 lines
---
 kernel/time/clocksource.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
kernel/time/clocksource.c +2 -1
index 50a8736..d2f6ddc 100644
@@ -714,7 +714,8 @@ static void clocksource_enqueue(struct clocksource *cs)
  * This should only be called from the clocksource->enable() method.
  *
  * This *SHOULD NOT* be called directly! Please use the
- * clocksource_updatefreq_hz() or clocksource_updatefreq_khz helper functions.
+ * __clocksource_updatefreq_hz() or __clocksource_updatefreq_khz helper
+ * functions.
  */
 void __clocksource_updatefreq_scale(struct clocksource *cs, u32 scale, u32 freq)
 {
Signature · 1 line
1.8.2.1
author
#2 lore raw
Quoted 8 lines · Thomas Gleixner
Quoted 3 lines · Xie XiuQi

The functions clocksource_updatefreq_hz() and clocksource_updatefreq_khz() do not exist, The proper ones are __clocksource_updatefreq_hz() and __clocksource_updatefreq_khz().

I'd rather rename the functions and the few call sites because the underscores are completely meaningless.

That's a good idea, thanks. I'll update this patch and send later.

Quoted 30 lines

Thanks,

tglx

Quoted 23 lines
---
 kernel/time/clocksource.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
kernel/time/clocksource.c +2 -1
index 50a8736..d2f6ddc 100644
@@ -714,7 +714,8 @@ static void clocksource_enqueue(struct clocksource *cs)
  * This should only be called from the clocksource->enable() method.
  *
  * This *SHOULD NOT* be called directly! Please use the
- * clocksource_updatefreq_hz() or clocksource_updatefreq_khz helper functions.
+ * __clocksource_updatefreq_hz() or __clocksource_updatefreq_khz helper
+ * functions.
  */
 void __clocksource_updatefreq_scale(struct clocksource *cs, u32 scale, u32 freq)
 {
Signature · 1 line
1.8.2.1