Skip to contentSkip to conversation

xfstests: check for valid input to _scratch_mkfs_sized

PATCH In review Eric Sandeen 3 participants 4 messages Sep 17, 2013 – Oct 16, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: check for valid input to _scratch_mkfs_sized

_scratch_mkfs_sized requires an integer number of bytes as input; if it's given something else, catch it and _notrun.

---

common/rc +9 -0
index 77e96c4..6afc164 100644
@@ -569,6 +569,15 @@ _scratch_mkfs_sized()
     fssize=$1
     blocksize=$2
     [ -z "$blocksize" ] && blocksize=4096
+
+    re='^[0-9]+$'
+    if ! [[ $fssize =~ $re ]] ; then
+        _notrun "error: _scratch_mkfs_sized: fs size \"$fssize\" not an integer."
+    fi
+    if ! [[ $blocksize =~ $re ]] ; then
+        _notrun "error: _scratch_mkfs_sized: block size \"$blocksize\" not an integer."
+    fi
+
     blocks=`expr $fssize / $blocksize`
 
     if [ "$HOSTOS" == "Linux" ]; then

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#2 lore raw
Quoted 8 lines · Mark Tinguely
Quoted 5 lines · Eric Sandeen

_scratch_mkfs_sized requires an integer number of bytes as input; if it's given something else, catch it and _notrun.

---

Ah, the "don't do what Mark did" patch.

the "make life easier for future Marks" patch. ;)

Quoted 1 line

Thanks!

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs