DaVinci fixes for v3.12-rc

GIT PULL Sekhar Nori 3 participants 6 messages Sep 19, 2013 – Sep 20, 2013

lore

Share & tools

lore

Sekhar Nori

author

2013-09-19 10:22 UTC #0 lore raw

The following changes since commit 272b98c6455f00884f0350f775c5342358ebb73f:

Linux 3.12-rc1 (2013-09-16 16:17:51 -0400)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/nsekhar/linux-davinci.git tags/davinci-fixes-for-v3.12-rc2

for you to fetch changes up to caf9269f883bf0d5b83384efb96e2aa572d1d013:

ARM: edma: dt: create unused channel list (2013-09-19 15:13:32 +0530)

----------------------------------------------------------------
DaVinci fixes for v3.12-rc2
---------------------------

This pull request includes:

1) A patch to fix build breakage with DEBUG_LL
2) A patch to quell a build-time warning.
3) A patch to complete the DT support for EDMA. Without this patch, the DT support for EDMA cannot be used. There are no in-tree DT users of EDMA currently but nevertheless the patch fixes a previously incomplete implementation.

----------------------------------------------------------------
Brian Norris (1):
ARM: davinci: dm365 evm: fix unused variable warning

Joel Fernandes (1):
ARM: edma: dt: create unused channel list

Sekhar Nori (1):
ARM: davinci: fix build breakage with DEBUG_LL

 arch/arm/common/edma.c                      |   39 ++++++++++++++++++++++-----
 arch/arm/mach-davinci/board-dm365-evm.c     |    2 +-
 arch/arm/mach-davinci/include/mach/serial.h |    4 +--
 3 files changed, 35 insertions(+), 10 deletions(-)

Olof Johansson

2013-09-19 17:48 UTC #1 lore raw

Hi Sekhar,

Quoted 18 lines · Sekhar Nori

The following changes since commit 272b98c6455f00884f0350f775c5342358ebb73f:
Linux 3.12-rc1 (2013-09-16 16:17:51 -0400)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/nsekhar/linux-davinci.git tags/davinci-fixes-for-v3.12-rc2
for you to fetch changes up to caf9269f883bf0d5b83384efb96e2aa572d1d013:
ARM: edma: dt: create unused channel list (2013-09-19 15:13:32 +0530)
----------------------------------------------------------------
DaVinci fixes for v3.12-rc2
---------------------------
This pull request includes:

Quoted 7 lines

1) A patch to fix build breakage with DEBUG_LL
2) A patch to quell a build-time warning.
3) A patch to complete the DT support for EDMA. Without this patch, the DT support for EDMA cannot be used. There are no in-tree DT users of EDMA currently but nevertheless the patch fixes a previously incomplete implementation.

Finishing incomplete work is not a fix, especially if the users aren't in-tree. The other patches are just fine to include though.

Want to rebuild the branch (and stage the EDMA work for 3.13), or should I pick the patches into branches at our end? Your choice.

-Olof

Sekhar Nori

author

2013-09-20 04:54 UTC #2 lore raw

Quoted 29 lines · Olof Johansson

Hi Sekhar,
Quoted 18 lines · Sekhar Nori
The following changes since commit 272b98c6455f00884f0350f775c5342358ebb73f:
Linux 3.12-rc1 (2013-09-16 16:17:51 -0400)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/nsekhar/linux-davinci.git tags/davinci-fixes-for-v3.12-rc2
for you to fetch changes up to caf9269f883bf0d5b83384efb96e2aa572d1d013:
ARM: edma: dt: create unused channel list (2013-09-19 15:13:32 +0530)
----------------------------------------------------------------
DaVinci fixes for v3.12-rc2
---------------------------
This pull request includes:
Quoted 7 lines
1) A patch to fix build breakage with DEBUG_LL
2) A patch to quell a build-time warning.
3) A patch to complete the DT support for EDMA. Without this patch, the DT support for EDMA cannot be used. There are no in-tree DT users of EDMA currently but nevertheless the patch fixes a previously incomplete implementation.

Quoted 2 lines

Finishing incomplete work is not a fix, especially if the users aren't in-tree. The other patches are just fine to include though.

Yes, its not a regression. Doesn't break any in-tree support really. I would not have sent it if it was late -rc cycle.

Quoted 3 lines

Want to rebuild the branch (and stage the EDMA work for 3.13), or should I pick the patches into branches at our end? Your choice.

I just sent you an updated pull request with the offending patch removed.

Thanks,
Sekhar

Alexander Holler

2013-09-20 06:06 UTC #3 lore raw

In reply to Olof Johansson

Am 19.09.2013 19:48, schrieb Olof Johansson:

Quoted 4 lines

Hi Sekhar,
Quoted 1 line · Sekhar Nori
The following changes since commit 272b98c6455f00884f0350f775c5342358ebb73f:

...

Quoted 8 lines

Quoted 5 lines
3) A patch to complete the DT support for EDMA. Without this patch, the DT support for EDMA cannot be used. There are no in-tree DT users of EDMA currently but nevertheless the patch fixes a previously incomplete implementation.
Finishing incomplete work is not a fix, especially if the users aren't in-tree. The other patches are just fine to include though.

It fixes problems for all people which are not using the provided DT's but using edma in their own DT. So I don't understand your arguing as DT got introduced to not only support in-tree configs. It clearly fixes problems.

Regards,

Alexander Holler

Olof Johansson

2013-09-20 17:40 UTC #4 lore raw

Hi,

Quoted 13 lines · Alexander Holler

Am 19.09.2013 19:48, schrieb Olof Johansson:
Quoted 4 lines
Hi Sekhar,
Quoted 1 line · Sekhar Nori
The following changes since commit 272b98c6455f00884f0350f775c5342358ebb73f:
...
Quoted 6 lines
Quoted 5 lines
3) A patch to complete the DT support for EDMA. Without this patch, the DT support for EDMA cannot be used. There are no in-tree DT users of EDMA currently but nevertheless the patch fixes a previously incomplete implementation.

Quoted 7 lines

Quoted 2 lines
Finishing incomplete work is not a fix, especially if the users aren't in-tree. The other patches are just fine to include though.
It fixes problems for all people which are not using the provided DT's but using edma in their own DT. So I don't understand your arguing as DT got introduced to not only support in-tree configs. It clearly fixes problems.

Right, that was the smaller part of the argument. The bigger is:
Completing a feature is not a fix. If the whole feature didn't make it in for a release, then the rest goes into the next release.

-Olof

Alexander Holler

2013-09-20 17:45 UTC #5 lore raw

Am 20.09.2013 19:40, schrieb Olof Johansson:

Quoted 19 lines

Hi,
Quoted 16 lines · Alexander Holler
Am 19.09.2013 19:48, schrieb Olof Johansson:
Quoted 4 lines
Hi Sekhar,
Quoted 1 line · Sekhar Nori
The following changes since commit 272b98c6455f00884f0350f775c5342358ebb73f:
...
Quoted 8 lines
Quoted 5 lines
3) A patch to complete the DT support for EDMA. Without this patch, the DT support for EDMA cannot be used. There are no in-tree DT users of EDMA currently but nevertheless the patch fixes a previously incomplete implementation.
Finishing incomplete work is not a fix, especially if the users aren't in-tree. The other patches are just fine to include though.

Quoted 8 lines

Quoted 4 lines
It fixes problems for all people which are not using the provided DT's but using edma in their own DT. So I don't understand your arguing as DT got introduced to not only support in-tree configs. It clearly fixes problems.
Right, that was the smaller part of the argument. The bigger is:
Completing a feature is not a fix. If the whole feature didn't make it in for a release, then the rest goes into the next release.

Bureaucrazy at it's best.

Regards,

Alexander Holler