Skip to contentSkip to conversation

Pull request

U-Boot NAK Heiko Schocher 2 participants 3 messages Oct 1, 2013 – Oct 2, 2013

lore
Share & tools
lore
#0 lore raw

Hello Tom,

please pull from u-boot-i2c.git

The following changes since commit 6b40852da5c8dd710f9d61204affff3c6a3c9d22:

Sound: MAX98095: Support I2S0 channel (2013-09-24 09:10:33 -0400)

are available in the git repository at:

git://git.denx.de/u-boot-i2c.git master

for you to fetch changes up to e436193269620579164d7db4296a3d7a378dbf8d:

exynos: i2c: Fix i2c driver to handle NACKs properly (2013-10-01 08:33:16 +0200)

----------------------------------------------------------------
Naveen Krishna Ch (1):
exynos: i2c: Fix i2c driver to handle NACKs properly

  drivers/i2c/s3c24x0_i2c.c | 213 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------------------------------------------
  1 file changed, 89 insertions(+), 124 deletions(-)

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#1 lore raw
Quoted 14 lines · Heiko Schocher

Hello Tom,

please pull from u-boot-i2c.git

The following changes since commit 6b40852da5c8dd710f9d61204affff3c6a3c9d22:

Sound: MAX98095: Support I2S0 channel (2013-09-24 09:10:33 -0400)

are available in the git repository at:

git://git.denx.de/u-boot-i2c.git master

for you to fetch changes up to e436193269620579164d7db4296a3d7a378dbf8d:

Quoted 8 lines

exynos: i2c: Fix i2c driver to handle NACKs properly (2013-10-01 08:33:16 +0200)

----------------------------------------------------------------
Naveen Krishna Ch (1):
exynos: i2c: Fix i2c driver to handle NACKs properly

 drivers/i2c/s3c24x0_i2c.c | 213 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------------------------------------------
 1 file changed, 89 insertions(+), 124 deletions(-)

NAK:

Testing VCMA9 on -00058-ga882b9e
Wed Oct 2 09:02:24 EDT 2013
Configuring for VCMA9 board...
s3c24x0_i2c.c:234:3: error: 'i' undeclared (first use in this
function)
make[1]: *** [/home/trini/work/u-boot/u-boot/VCMA9/drivers/i2c/s3c24x0_i2c.o] Error 1
make: *** [/home/trini/work/u-boot/u-boot/VCMA9/drivers/i2c/libi2c.o] Error 2 /opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.7-2013.03-20130313_linux/bin/arm-linux-gnueabihf-size: 'VCMA9/u-boot': No such file s3c24x0_i2c.c: In function 'i2c_init':
s3c24x0_i2c.c:234:3: error: 'i' undeclared (first use in this function)
s3c24x0_i2c.c:234:3: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [/home/trini/work/u-boot/u-boot/VCMA9/drivers/i2c/s3c24x0_i2c.o] Error 1
make: *** [/home/trini/work/u-boot/u-boot/VCMA9/drivers/i2c/libi2c.o] Error 2
make: *** Waiting for unfinished jobs....

--------------------- SUMMARY ---------------------------- Boards compiled: 1
Boards with errors: 1 ( VCMA9 )
----------------------------------------------------------
Command exited with non-zero status 1

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131002/da5bcdf0/attachment.pgp>
#2 lore raw

Hello Tom,

Am 02.10.2013 15:04, schrieb Tom Rini:

Quoted 25 lines · Heiko Schocher
Quoted 15 lines

Hello Tom,

please pull from u-boot-i2c.git

The following changes since commit 6b40852da5c8dd710f9d61204affff3c6a3c9d22:

   Sound: MAX98095: Support I2S0 channel (2013-09-24 09:10:33 -0400)

are available in the git repository at:

   git://git.denx.de/u-boot-i2c.git master

for you to fetch changes up to e436193269620579164d7db4296a3d7a378dbf8d:

Quoted 8 lines
   exynos: i2c: Fix i2c driver to handle NACKs properly (2013-10-01 08:33:16 +0200)

----------------------------------------------------------------
Naveen Krishna Ch (1):
exynos: i2c: Fix i2c driver to handle NACKs properly

  drivers/i2c/s3c24x0_i2c.c | 213 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------------------------------------------
  1 file changed, 89 insertions(+), 124 deletions(-)
Quoted 6 lines

NAK:

Testing VCMA9 on -00058-ga882b9e
Wed Oct 2 09:02:24 EDT 2013
Configuring for VCMA9 board...
s3c24x0_i2c.c:234:3: error: 'i' undeclared (first use in this

Ups, Thanks for detecting this ...

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany