Skip to contentSkip to conversation

i2c-mux-gpio: use deferred probing with the device tree

PATCH In review Ionut Nicu 3 participants 6 messages Oct 8, 2013 – Oct 9, 2013

Subsystems (3)
I2C subsystem host drivers I2C muxes Generic GPIO I2C multiplexer driver
lore
Share & tools
lore

Ionut Nicu

author
#0 lore raw

PATCH 1/2 i2c-mux-gpio: use deferred probing with the device tree

If the i2c-parent bus driver is not loaded, returning -EINVAL will force people to unload and then reload the module again to get it working.

Signed-off-by Ionut Nicu <[email protected]>
---
 drivers/i2c/muxes/i2c-mux-gpio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/i2c/muxes/i2c-mux-gpio.c +1 -1
index 5d4a99b..eb99f04 100644
@@ -79,7 +79,7 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
 	adapter = of_find_i2c_adapter_by_node(adapter_np);
 	if (!adapter) {
 		dev_err(&pdev->dev, "Cannot find parent bus\n");
-		return -ENODEV;
+		return -EPROBE_DEFER;
 	}
 	mux->data.parent = i2c_adapter_id(adapter);
 	put_device(&adapter->dev);
Signature · 1 line
1.7.1
maintainer Acked-by on v1 1/2
#1 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"IN" == Ionut Nicu <[email protected]> writes:

IN> If the i2c-parent bus driver is not loaded, returning IN> -EINVAL will force people to unload and then reload the IN> module again to get it working.

IN> Signed-off-by: Ionut Nicu <[email protected]>

Acked-by Peter Korsgaard <peter.korsgaard-ob4gmnvZ1/[email protected]>

--
Sorry about disclaimer - It's out of my control.
Bye, Peter Korsgaard
This message is subject to the following terms and conditions: MAIL DISCLAIMER<http://www.barco.com/en/maildisclaimer>

#2 lore raw
In reply to Ionut Nicu
Quoted 5 lines · Ionut Nicu

If the i2c-parent bus driver is not loaded, returning -EINVAL will force people to unload and then reload the module again to get it working.

Signed-off-by Ionut Nicu <[email protected]>

Doesn't the non-DT case need fixing, too?

Quoted 19 lines
---
 drivers/i2c/muxes/i2c-mux-gpio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/i2c/muxes/i2c-mux-gpio.c +1 -1
index 5d4a99b..eb99f04 100644
@@ -79,7 +79,7 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
 	adapter = of_find_i2c_adapter_by_node(adapter_np);
 	if (!adapter) {
 		dev_err(&pdev->dev, "Cannot find parent bus\n");
-		return -ENODEV;
+		return -EPROBE_DEFER;
 	}
 	mux->data.parent = i2c_adapter_id(adapter);
 	put_device(&adapter->dev);
Signature · 1 line
1.7.1
maintainer
#3 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"WS" == Wolfram Sang <wsa-z923LK4zBo2bacvFa/[email protected]> writes:

Quoted 5 lines · Ionut Nicu
Quoted 5 lines

If the i2c-parent bus driver is not loaded, returning -EINVAL will force people to unload and then reload the module again to get it working.

Signed-off-by Ionut Nicu <[email protected]>

WS> Doesn't the non-DT case need fixing, too?

Arguably yes.

--
Bye, Peter Korsgaard
This message is subject to the following terms and conditions: MAIL DISCLAIMER<http://www.barco.com/en/maildisclaimer>

author
#4 lore raw
Quoted 7 lines · ext Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"WS" == Wolfram Sang <wsa-z923LK4zBo2bacvFa/[email protected]> writes:

Quoted 4 lines · Ionut Nicu
Quoted 4 lines

If the i2c-parent bus driver is not loaded, returning -EINVAL will force people to unload and then reload the module again to get it working.

Quoted 6 lines
Quoted 1 line
Quoted 1 line
Signed-off-by Ionut Nicu <[email protected]>

WS> Doesn't the non-DT case need fixing, too?

Arguably yes.

Yes, and it's also a one line fix. Should I do it in a separate patch or should I change this one and resubmit?

#5 lore raw
Quoted 6 lines
Quoted 3 lines

WS> Doesn't the non-DT case need fixing, too?

Arguably yes.

Yes, and it's also a one line fix. Should I do it in a separate patch or should I change this one and resubmit?

Resubmit please.