Skip to contentSkip to conversation

xfstests: fix xfs/205 for new log size defaults

PATCH In review Eric Sandeen 3 participants 3 messages Oct 9, 2013 – Oct 16, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: fix xfs/205 for new log size defaults

test xfs/205 expects a certain log size, but defaults have changed, the logs are bigger, and this test now fails w/ early ENOSPC:

QA output created by 205
+ !!! disk full (expected)
+ !!! disk full (expected)
+ !!! disk full (expected)
*** one file
+ !!! disk full (expected)
*** one file, a few bytes at a time
...

Fix this by specifying the log size at mkfs time, so freespace is as the test expects it to be.

---

tests/xfs/205 +1 -1
index c9b73a1..0c071ca 100755
@@ -41,7 +41,7 @@ _require_scratch
 
 rm -f $seqres.full
 
-_scratch_mkfs_xfs -d size=16m -b size=512 >> $seqres.full 2>&1
+_scratch_mkfs_xfs -d size=16m -b size=512 -l size=4944b >> $seqres.full 2>&1
 _scratch_mount
 
 # fix the reserve block pool to a known size so that the enospc calculations

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#1 lore raw
Quoted 13 lines · Eric Sandeen

test xfs/205 expects a certain log size, but defaults have changed, the logs are bigger, and this test now fails w/ early ENOSPC:

QA output created by 205
+ !!! disk full (expected)
+ !!! disk full (expected)
+ !!! disk full (expected)
*** one file
+ !!! disk full (expected)
*** one file, a few bytes at a time
...

Quoted 2 lines

Fix this by specifying the log size at mkfs time, so freespace is as the test expects it to be.

Looks good.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs