i2c-mux-gpio: use gpio_set_value_cansleep()

Some gpio chips may have get/set operations that can sleep. gpio_set_value() only works for chips which do not sleep, for the others we will get a kernel warning. Using gpio_set_value_cansleep() will work for both chips that do sleep and those who don't.

---
 drivers/i2c/muxes/i2c-mux-gpio.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

index a764da7..550e094 100644
@@ -30,8 +30,8 @@ static void i2c_mux_gpio_set(const struct gpiomux *mux, unsigned val)
 	int i;
 
 	for (i = 0; i < mux->data.n_gpios; i++)
-		gpio_set_value(mux->gpio_base + mux->data.gpios[i],
-			       val & (1 << i));
+		gpio_set_value_cansleep(mux->gpio_base + mux->data.gpios[i],
+				val & (1 << i));
 }
 
 static int i2c_mux_gpio_select(struct i2c_adapter *adap, void *data, u32 chan)

1.7.1

IN> Some gpio chips may have get/set operations that IN> can sleep. gpio_set_value() only works for chips IN> which do not sleep, for the others we will get a IN> kernel warning. Using gpio_set_value_cansleep() IN> will work for both chips that do sleep and those IN> who don't.

IN> Signed-off-by: Ionut Nicu <[email protected]> IN> ---
IN> drivers/i2c/muxes/i2c-mux-gpio.c | 4 ++--
IN> 1 files changed, 2 insertions(+), 2 deletions(-)

IN> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c IN> index a764da7..550e094 100644
IN> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
IN> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
IN> @@ -30,8 +30,8 @@ static void i2c_mux_gpio_set(const struct gpiomux *mux, unsigned val)
IN> int i;

IN> for (i = 0; i < mux->data.n_gpios; i++)
IN> - gpio_set_value(mux->gpio_base + mux->data.gpios[i],
IN> - val & (1 << i));
IN> + gpio_set_value_cansleep(mux->gpio_base + mux->data.gpios[i],
IN> + val & (1 << i));

The indentation of the 2nd line seems wrong (should match mux->gpio_base), otherwise it looks good:

--
Sorry about disclaimer - It's out of my control.
Bye, Peter Korsgaard
This message is subject to the following terms and conditions: MAIL DISCLAIMER<http://www.barco.com/en/maildisclaimer>