Skip to contentSkip to conversation

mke2fs: fix force option to create filesystem on mounted device

PATCH RESEND Superseded Kazuya Mio 2 participants 2 messages Oct 25, 2013

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Kazuya Mio

author
#0 lore raw

PATCH RESEND 1/1 mke2fs: fix force option to create filesystem on mounted device

According to mke2fs man, we can create a filesystem on the mounted device when -FF option is specified.
However, currently we have to specify -F option third to force mke2fs. This patch fixes the problem.

---
 misc/util.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
misc/util.c +2 -2
index 6c93e1c..40c8858 100644
@@ -150,7 +150,7 @@ void check_mount(const char *device, int force, const char *type)
 	}
 	if (mount_flags & EXT2_MF_MOUNTED) {
 		fprintf(stderr, _("%s is mounted; "), device);
-		if (force > 2) {
+		if (force >= 2) {
 			fputs(_("mke2fs forced anyway.  Hope /etc/mtab is "
 				"incorrect.\n"), stderr);
 			return;
@@ -162,7 +162,7 @@ void check_mount(const char *device, int force, const char *type)
 	if (mount_flags & EXT2_MF_BUSY) {
 		fprintf(stderr, _("%s is apparently in use by the system; "),
 			device);
-		if (force > 2) {
+		if (force >= 2) {
 			fputs(_("mke2fs forced anyway.\n"), stderr);
 			return;
 		}
Reviewed-by on v1 1/1
#1 lore raw

Looks good,

Quoted 37 lines · Kazuya Mio

According to mke2fs man, we can create a filesystem on the mounted device when -FF option is specified.
However, currently we have to specify -F option third to force mke2fs. This patch fixes the problem.

---
 misc/util.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
misc/util.c +2 -3
index 6c93e1c..40c8858 100644
@@ -150,7 +150,7 @@ void check_mount(const char *device, int force, const char *type)
 	}
 	if (mount_flags & EXT2_MF_MOUNTED) {
 		fprintf(stderr, _("%s is mounted; "), device);
-		if (force > 2) {
+		if (force >= 2) {
 			fputs(_("mke2fs forced anyway.  Hope /etc/mtab is "
 				"incorrect.\n"), stderr);
 			return;
@@ -162,7 +162,7 @@ void check_mount(const char *device, int force, const char *type)
 	if (mount_flags & EXT2_MF_BUSY) {
 		fprintf(stderr, _("%s is apparently in use by the system; "),
 			device);
-		if (force > 2) {
+		if (force >= 2) {
 			fputs(_("mke2fs forced anyway.\n"), stderr);
 			return;
 		}
--

To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 1 line
Carlos