seq_file: always update file->f_pos in seq_lseek()
PATCH 1/1 seq_file: always update file->f_pos in seq_lseek()
This issue was first pointed out by Jiaxing Wang several months ago, but no further comments:
https://lkml.org/lkml/2013/6/29/41
As we know pread() does not change f_pos, so after pread(), file->f_pos and m->read_pos become different. And seq_lseek() does not update file->f_pos if offset equals to m->read_pos, so after pread() and seq_lseek()(lseek to m->read_pos), then a subsequent read may read from a wrong position, the following program produces the problem:
char str1[32] = { 0 };
char str2[32] = { 0 };
int poffset = 10;
int count = 20;
/*open any seq file*/
int fd = open("/proc/modules", O_RDONLY);
pread(fd, str1, count, poffset);
printf("pread:%s\n", str1);
/*seek to where m->read_pos is*/
lseek(fd, poffset+count, SEEK_SET);
/*supposed to read from poffset+count, but this read from position 0*/
read(fd, str2, count);
printf("read:%s\n", str2);out put:
pread:
ck_netbios_ns 12665
read:
nf_conntrack_netbios
/proc/modules:nf_conntrack_netbios_ns 12665 0 - Live 0xffffffffa038b000 nf_conntrack_broadcast 12589 1 nf_conntrack_netbios_ns, Live 0xffffffffa0386000
So we always update file->f_pos to offset in seq_lseek() to fix this issue.
--- fs/seq_file.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
fs/seq_file.c +2 -0
@@ -328,6 +328,8 @@ loff_t seq_lseek(struct file *file, loff_t offset, int whence) m->read_pos = offset; retval = file->f_pos = offset; } + }else { + file->f_pos = offset; } } file->f_version = m->version;
Signature · 1 line
1.7.7
Quoted 52 lines · Gu Zheng
This issue was first pointed out by Jiaxing Wang several months ago, but no further comments:
https://lkml.org/lkml/2013/6/29/41As we know
pread()does not changef_pos, so afterpread(),file->f_posandm->read_posbecome different. Andseq_lseek()does not updatefile->f_posif offset equals tom->read_pos, so afterpread()and seq_lseek()(lseek tom->read_pos), then a subsequent read may read from a wrong position, the following program produces the problem:char str1[32] = { 0 }; char str2[32] = { 0 }; int poffset = 10; int count = 20; /*open any seq file*/ int fd = open("/proc/modules", O_RDONLY); pread(fd, str1, count, poffset); printf("pread:%s\n", str1); /*seek to where m->read_pos is*/ lseek(fd, poffset+count, SEEK_SET); /*supposed to read from poffset+count, but this read from position 0*/ read(fd, str2, count); printf("read:%s\n", str2);out put:
pread:
ck_netbios_ns12665
read:
nf_conntrack_netbios
/proc/modules:nf_conntrack_netbios_ns12665 0 - Live0xffffffffa038b000nf_conntrack_broadcast12589 1nf_conntrack_netbios_ns, Live0xffffffffa0386000So we always update
file->f_posto offset inseq_lseek()to fix this issue.Signed-off-by Jiaxing Wang <[email protected]>Signed-off-by Gu Zheng <[email protected]>--- fs/seq_file.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)fs/seq_file.c +0
-0
fs/seq_file.c loff_t seq_lseek(struct file *file, loff_t offset, int whence) · line 335
Quoted 8 lines
fs/seq_file.c +2
-0@@ -328,6 +328,8 @@ loff_t seq_lseek(struct file *file, loff_t offset, int whence) m->read_pos = offset; retval = file->f_pos = offset; } + }else { + file->f_pos = offset; } } file->f_version = m->version;
Thanks Gu, I should have post this patch again. And Viro, please take a few minutes to review this, thanks.