Skip to contentSkip to conversation

osm_ucast_cache.c: Fix memory leak in ucast_cache

PATCH New Hal Rosenstock 1 participant 1 message Oct 28, 2013 InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 osm_ucast_cache.c: Fix memory leak in ucast_cache

From: Alex Netes <alexne-VPRAkNaXOzVWk0Htik3J/[email protected]>

When invalidating cache p_sw->hops[i] arrays aren't cleared.

---
 opensm/osm_ucast_cache.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)
opensm/osm_ucast_cache.c +7 -1
index e3f7c7b..2238ba3 100644
@@ -114,13 +114,19 @@ static cache_switch_t *cache_sw_new(uint16_t lid_ho, unsigned num_ports)
 
 static void cache_sw_destroy(cache_switch_t * p_sw)
 {
+	unsigned i;
+
 	if (!p_sw)
 		return;
 
 	if (p_sw->lft)
 		free(p_sw->lft);
-	if (p_sw->hops)
+	if (p_sw->hops) {
+		for (i = 0; i < p_sw->num_hops; i++)
+			if (p_sw->hops[i])
+				free(p_sw->hops[i]);
 		free(p_sw->hops);
+	}
 	free(p_sw);
 }
 
Signature · 6 lines
1.7.8.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html