Skip to contentSkip to conversation

Subject: [v3.8][v3.11][Regression] [SCSI] sd: Update WRITE SAME heuristics

DISCUSSION Joseph Salisbury 4 participants 7 messages Oct 29, 2013 – Oct 31, 2013 SCSI

lore
Share & tools
lore
#0 lore raw

Hi Martin,

A bug was opened against the Ubuntu kernel[0]. After a kernel bisect, it was found that reverting the following commit resolved this bug:

commit 66c28f97120e8a621afd5aa7a31c4b85c547d33d

Author: Martin K. Petersen <[email protected]>
Date:   Thu Jun 6 22:15:55 2013 -0400

[SCSI] sd: Update WRITE SAME heuristics

The regression was introduced as of v3.11-rc1, but it also made it's way into the stable trees.

I see that you are the author of this patch, so I wanted to run this by you. I was thinking of requesting a revert for v3.12, but I wanted to get your feedback first.

Thanks,

Joe

[0] http://pad.lv/1237392

#1 lore raw
Quoted 20 lines · Joseph Salisbury

Hi Martin,

A bug was opened against the Ubuntu kernel[0]. After a kernel bisect, it was found that reverting the following commit resolved this bug:

commit 66c28f97120e8a621afd5aa7a31c4b85c547d33d

Author: Martin K. Petersen <[email protected]>
Date:   Thu Jun 6 22:15:55 2013 -0400

[SCSI] sd: Update WRITE SAME heuristics

The regression was introduced as of v3.11-rc1, but it also made it's way into the stable trees.

I see that you are the author of this patch, so I wanted to run this by you. I was thinking of requesting a revert for v3.12, but I wanted to get your feedback first.

Quoted 5 lines

Thanks,

Joe

[0] http://pad.lv/1237392

Tried the other approach?

From your bug report: "Areca Raid Controller2: F/W v1.46 ...(etc)..."

Then see:
http://www.areca.com.tw/support/main.htm

Doug Gilbert

#3 lore raw
In reply to Joseph Salisbury

Hello Joseph,

Quoted 12 lines · Joseph Salisbury

Hi Martin,

A bug was opened against the Ubuntu kernel[0]. After a kernel bisect, it was found that reverting the following commit resolved this bug:

commit 66c28f97120e8a621afd5aa7a31c4b85c547d33d

Author: Martin K. Petersen <[email protected]>
Date:   Thu Jun 6 22:15:55 2013 -0400

[SCSI] sd: Update WRITE SAME heuristics

Quoted 7 lines

The regression was introduced as of v3.11-rc1, but it also made it's way into the stable trees.

I see that you are the author of this patch, so I wanted to run this by you. I was thinking of requesting a revert for v3.12, but I wanted to get your feedback first.

James queued this up for 3.13

Quoted 1 line

http://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/commit/?id=735e39e680256a13e7be3492acfb4d9721287a42

Maybe we should try to convince James to take it into 3.12?

Cheers,
Bernd

#4 lore raw
Quoted 25 lines · Bernd Schubert

Hello Joseph,

Quoted 12 lines · Joseph Salisbury

Hi Martin,

A bug was opened against the Ubuntu kernel[0]. After a kernel bisect, it was found that reverting the following commit resolved this bug:

commit 66c28f97120e8a621afd5aa7a31c4b85c547d33d

Author: Martin K. Petersen <[email protected]>
Date:   Thu Jun 6 22:15:55 2013 -0400

[SCSI] sd: Update WRITE SAME heuristics

Quoted 7 lines

The regression was introduced as of v3.11-rc1, but it also made it's way into the stable trees.

I see that you are the author of this patch, so I wanted to run this by you. I was thinking of requesting a revert for v3.12, but I wanted to get your feedback first.

James queued this up for 3.13

Quoted 8 lines
Quoted 2 lines

http://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/commit/?id=735e39e680256a13e7be3492acfb4d9721287a42

Maybe we should try to convince James to take it into 3.12?

Cheers,
Bernd

I'll build a 3.12 test kernel with this commit and ask the bug reporter to test it. Thanks for the pointer, Bernd.

#2 lore raw
In reply to Douglas Gilbert
Quoted 27 lines · Douglas Gilbert
Quoted 20 lines · Joseph Salisbury

Hi Martin,

A bug was opened against the Ubuntu kernel[0]. After a kernel bisect, it was found that reverting the following commit resolved this bug:

commit 66c28f97120e8a621afd5aa7a31c4b85c547d33d

Author: Martin K. Petersen <[email protected]>
Date:   Thu Jun 6 22:15:55 2013 -0400

[SCSI] sd: Update WRITE SAME heuristics

The regression was introduced as of v3.11-rc1, but it also made it's way into the stable trees.

I see that you are the author of this patch, so I wanted to run this by you. I was thinking of requesting a revert for v3.12, but I wanted to get your feedback first.

Quoted 5 lines

Thanks,

Joe

[0] http://pad.lv/1237392

Quoted 11 lines

Tried the other approach?

From your bug report: "Areca Raid Controller2: F/W v1.46 ...(etc)..."

Then see:
http://www.areca.com.tw/support/main.htm

Doug Gilbert

Thanks, Doug. I'm going to give the patch[0] written by Bernd Schubert a try first. If the issue still persists, I'll ask the bug reporter to upgrade the firmware.

[0]
http://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/commit/?id=735e39e680256a13e7be3492acfb4d9721287a42

#5 lore raw
In reply to Bernd Schubert
Quoted 25 lines · Bernd Schubert

Hello Joseph,

Quoted 12 lines · Joseph Salisbury

Hi Martin,

A bug was opened against the Ubuntu kernel[0]. After a kernel bisect, it was found that reverting the following commit resolved this bug:

commit 66c28f97120e8a621afd5aa7a31c4b85c547d33d

Author: Martin K. Petersen <[email protected]>
Date:   Thu Jun 6 22:15:55 2013 -0400

[SCSI] sd: Update WRITE SAME heuristics

Quoted 7 lines

The regression was introduced as of v3.11-rc1, but it also made it's way into the stable trees.

I see that you are the author of this patch, so I wanted to run this by you. I was thinking of requesting a revert for v3.12, but I wanted to get your feedback first.

James queued this up for 3.13

Quoted 8 lines
Quoted 2 lines

http://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/commit/?id=735e39e680256a13e7be3492acfb4d9721287a42

Maybe we should try to convince James to take it into 3.12?

Cheers,
Bernd

Hi Bernd,

The bug reporter confirms that your patch fixes the bug. Any chance this patch can make it into 3.12?

Thanks,

Joe

#6 lore raw
Quoted 4 lines · Joseph Salisbury

Hi Bernd,

The bug reporter confirms that your patch fixes the bug. Any chance this patch can make it into 3.12?

FWIW, I don't think reverting the WRITE SAME patch is an option -- it causes serious filesystem failures.

-hpa