Skip to contentSkip to conversation

Move drivers/acpi/apei/cper.c to drivers/firmware/efi/

GIT PULL Luck, Tony 3 participants 5 messages Oct 29, 2013 – Nov 1, 2013

lore
Share & tools
lore

Luck, Tony

author
#0 lore raw

The following changes since commit 56507694de3453076d73e0e9813349586ee67e59:

EDAC, GHES: Update ghes error record info (2013-10-23 10:11:00 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git tags/please-pull-move-cper

for you to fetch changes up to c57a801195153e111bcd712680a718cf101b6d1f:

Move cper.c from drivers/acpi/apei to drivers/firmware/efi (2013-10-29 09:23:38 -0700)

----------------------------------------------------------------
cper.c implements UEFI Appendix N "Common Platform Error Record" handling. Move it to drivers/firmware/efi/cper.c to reflect this heritage.

----------------------------------------------------------------
Tony Luck (1):
Move cper.c from drivers/acpi/apei to drivers/firmware/efi

 drivers/acpi/Kconfig                       | 4 +++-
 drivers/acpi/apei/Kconfig                  | 2 ++
 drivers/acpi/apei/Makefile                 | 2 +-
 drivers/firmware/efi/Kconfig               | 3 +++
 drivers/firmware/efi/Makefile              | 1 +
 drivers/{acpi/apei => firmware/efi}/cper.c | 0
 6 files changed, 10 insertions(+), 2 deletions(-)
 rename drivers/{acpi/apei => firmware/efi}/cper.c (100%)
#1 lore raw
Quoted 21 lines · Luck, Tony

The following changes since commit 56507694de3453076d73e0e9813349586ee67e59:

EDAC, GHES: Update ghes error record info (2013-10-23 10:11:00 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git tags/please-pull-move-cper

for you to fetch changes up to c57a801195153e111bcd712680a718cf101b6d1f:

Move cper.c from drivers/acpi/apei to drivers/firmware/efi (2013-10-29 09:23:38 -0700)

----------------------------------------------------------------
cper.c implements UEFI Appendix N "Common Platform Error Record" handling. Move it to drivers/firmware/efi/cper.c to reflect this heritage.

----------------------------------------------------------------
Tony Luck (1):
Move cper.c from drivers/acpi/apei to drivers/firmware/efi

Quoted 8 lines
 drivers/acpi/Kconfig                       | 4 +++-
 drivers/acpi/apei/Kconfig                  | 2 ++
 drivers/acpi/apei/Makefile                 | 2 +-
 drivers/firmware/efi/Kconfig               | 3 +++
 drivers/firmware/efi/Makefile              | 1 +
 drivers/{acpi/apei => firmware/efi}/cper.c | 0
 6 files changed, 10 insertions(+), 2 deletions(-)
 rename drivers/{acpi/apei => firmware/efi}/cper.c (100%)

Pulled, thanks Tony!

Ingo

#2 lore raw
In reply to Luck, Tony
Quoted 21 lines · Luck, Tony

The following changes since commit 56507694de3453076d73e0e9813349586ee67e59:

EDAC, GHES: Update ghes error record info (2013-10-23 10:11:00 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git tags/please-pull-move-cper

for you to fetch changes up to c57a801195153e111bcd712680a718cf101b6d1f:

Move cper.c from drivers/acpi/apei to drivers/firmware/efi (2013-10-29 09:23:38 -0700)

----------------------------------------------------------------
cper.c implements UEFI Appendix N "Common Platform Error Record" handling. Move it to drivers/firmware/efi/cper.c to reflect this heritage.

----------------------------------------------------------------
Tony Luck (1):
Move cper.c from drivers/acpi/apei to drivers/firmware/efi

Quoted 8 lines
 drivers/acpi/Kconfig                       | 4 +++-
 drivers/acpi/apei/Kconfig                  | 2 ++
 drivers/acpi/apei/Makefile                 | 2 +-
 drivers/firmware/efi/Kconfig               | 3 +++
 drivers/firmware/efi/Makefile              | 1 +
 drivers/{acpi/apei => firmware/efi}/cper.c | 0
 6 files changed, 10 insertions(+), 2 deletions(-)
 rename drivers/{acpi/apei => firmware/efi}/cper.c (100%)

Hm, it's not very well tested:

drivers/firmware/efi/Kconfig:41: syntax error drivers/firmware/efi/Kconfig:40: unknown option "defbool"

Thanks,

Ingo

#3 lore raw
Quoted 4 lines · Ingo Molnar

Hm, it's not very well tested:

drivers/firmware/efi/Kconfig:41: syntax error drivers/firmware/efi/Kconfig:40: unknown option "defbool"

Gah! That's exactly what I found yesterday ... and fixed the typo to change to "def_bool" ... and *tried* to "git --amend" before I tagged and sent the pull.

To mash up Yoda and Mythbusters:
There is no try - only fail

Just re-did it ... and according to gitweb the new tag is there and points at the new commit with the "def_bool" version.

Please try the pull again (same tag name as before) ... so the stuff below is right except new pull will:

... fetch changes up to 7ea6c6c15ee16f4c7f5eeaa62f77e696f85ae0d1:

Sorry for the inconvenience

-Tony

Quoted 32 lines · Luck, Tony
Quoted 30 lines

The following changes since commit 56507694de3453076d73e0e9813349586ee67e59:

EDAC, GHES: Update ghes error record info (2013-10-23 10:11:00 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git tags/please-pull-move-cper

for you to fetch changes up to c57a801195153e111bcd712680a718cf101b6d1f:

Move cper.c from drivers/acpi/apei to drivers/firmware/efi (2013-10-29 09:23:38 -0700)

----------------------------------------------------------------
cper.c implements UEFI Appendix N "Common Platform Error Record" handling. Move it to drivers/firmware/efi/cper.c to reflect this heritage.

----------------------------------------------------------------
Tony Luck (1):
Move cper.c from drivers/acpi/apei to drivers/firmware/efi

 drivers/acpi/Kconfig                       | 4 +++-
 drivers/acpi/apei/Kconfig                  | 2 ++
 drivers/acpi/apei/Makefile                 | 2 +-
 drivers/firmware/efi/Kconfig               | 3 +++
 drivers/firmware/efi/Makefile              | 1 +
 drivers/{acpi/apei => firmware/efi}/cper.c | 0
 6 files changed, 10 insertions(+), 2 deletions(-)
 rename drivers/{acpi/apei => firmware/efi}/cper.c (100%)
#4 lore raw
Quoted 6 lines · Tony Luck
Quoted 4 lines · Ingo Molnar

Hm, it's not very well tested:

drivers/firmware/efi/Kconfig:41: syntax error drivers/firmware/efi/Kconfig:40: unknown option "defbool"

Quoted 6 lines

Gah! That's exactly what I found yesterday ... and fixed the typo to change to "def_bool" ... and *tried* to "git --amend" before I tagged and sent the pull.

To mash up Yoda and Mythbusters:
There is no try - only fail

;-)

Quoted 2 lines

Just re-did it ... and according to gitweb the new tag is there and points at the new commit with the "def_bool" version.

Looks good here, thanks Tony!

Ingo