Skip to contentSkip to conversation

include/linux/wait.h: add ';' for the statement which missed it.

PATCH In review Chen Gang 3 participants 4 messages Oct 30, 2013 – Oct 31, 2013 Scheduler

lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 include/linux/wait.h: add ';' for the statement which missed it.

Add ';' for the statement, or can not pass compiling. The related error (for powerpc allmodconfig):

CC block/blk-mq.o
block/blk-mq.c: In function ‘blk_mq_queue_enter’:
block/blk-mq.c:108:8: error: expected ‘;’ before ‘__ret’ block/blk-mq.c:108:6: error: void value not ignored as it ought to be

---
 include/linux/wait.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/wait.h +1 -1
index 7f8caa5..fcc9680 100644
@@ -768,7 +768,7 @@ do {									\
 	int __ret = 0;							\
 	if (!(condition))						\
 		__ret = __wait_event_interruptible_lock_irq(wq,		\
-						condition, lock,)	\
+						condition, lock,);	\
 	__ret;								\
 })
 
Signature · 1 line
1.7.7.6
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Chen Gang

Add ';' for the statement, or can not pass compiling. The related error (for powerpc allmodconfig):

CC block/blk-mq.o
block/blk-mq.c: In function ‘blk_mq_queue_enter’:
block/blk-mq.c:108:8: error: expected ‘;’ before ‘__ret’ block/blk-mq.c:108:6: error: void value not ignored as it ought to be

I have that same patch on my machine but never posted it.

Thanks.

Quoted 18 lines
---
 include/linux/wait.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/wait.h +1 -1
index 7f8caa5..fcc9680 100644
@@ -768,7 +768,7 @@ do {									\
 	int __ret = 0;							\
 	if (!(condition))						\
 		__ret = __wait_event_interruptible_lock_irq(wq,		\
-						condition, lock,)	\
+						condition, lock,);	\
 	__ret;								\
 })
 
Signature · 1 line
~Randy
maintainer
#2 lore raw
Quoted 10 lines · Randy Dunlap
Quoted 9 lines · Chen Gang

Add ';' for the statement, or can not pass compiling. The related error (for powerpc allmodconfig):

CC block/blk-mq.o
block/blk-mq.c: In function ‘blk_mq_queue_enter’:
block/blk-mq.c:108:8: error: expected ‘;’ before ‘__ret’ block/blk-mq.c:108:6: error: void value not ignored as it ought to be

Quoted 5 lines
Quoted 1 line

I have that same patch on my machine but never posted it.

tip already includes commit 92ec11809565cf6429c75204e99e0f583b5c9d7c from the 23th which should fix this.

author
#3 lore raw
Quoted 11 lines · Peter Zijlstra
Quoted 10 lines · Randy Dunlap
Quoted 9 lines · Chen Gang

Add ';' for the statement, or can not pass compiling. The related error (for powerpc allmodconfig):

CC block/blk-mq.o
block/blk-mq.c: In function ‘blk_mq_queue_enter’:
block/blk-mq.c:108:8: error: expected ‘;’ before ‘__ret’ block/blk-mq.c:108:6: error: void value not ignored as it ought to be

Quoted 10 lines
Quoted 5 lines
Quoted 1 line

I have that same patch on my machine but never posted it.

tip already includes commit 92ec11809565cf6429c75204e99e0f583b5c9d7c from the 23th which should fix this.

Thank all of you.

Signature · 1 line
Chen Gang