Skip to contentSkip to conversation

cpufreq: ondemand: Remove redundant return statement

PATCH Applied Stratos Karafotis 3 participants 4 messages Oct 31, 2013 – Nov 1, 2013 CPU frequency scaling framework

lore
Share & tools
lore

Stratos Karafotis

author
#0 lore raw

PATCH 1/1 cpufreq: ondemand: Remove redundant return statement

After commit dfa5bb622555d9da0df21b50f46ebdeef390041b "cpufreq: ondemand: Change the calculation of target frequency", this return statement is no longer needed.

Reported-by Henrik Nilsson <[email protected]>
Signed-off-by Stratos Karafotis <[email protected]>
---
 drivers/cpufreq/cpufreq_ondemand.c | 1 -
 1 file changed, 1 deletion(-)
drivers/cpufreq/cpufreq_ondemand.c +0 -1
index 32f26f6..18d4091 100644
@@ -168,7 +168,6 @@ static void od_check_cpu(int cpu, unsigned int load)
 			dbs_info->rate_mult =
 				od_tuners->sampling_down_factor;
 		dbs_freq_increase(policy, policy->max);
-		return;
 	} else {
 		/* Calculate the next frequency proportional to load */
 		unsigned int freq_next;
Signature · 1 line
1.8.3.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 15 lines · Stratos Karafotis

After commit dfa5bb622555d9da0df21b50f46ebdeef390041b "cpufreq: ondemand: Change the calculation of target frequency", this return statement is no longer needed.

Reported-by Henrik Nilsson <[email protected]>
Signed-off-by Stratos Karafotis <[email protected]>
---
 drivers/cpufreq/cpufreq_ondemand.c | 1 -
 1 file changed, 1 deletion(-)
drivers/cpufreq/cpufreq_ondemand.c +0 -0
index 32f26f6..18d4091 100644

drivers/cpufreq/cpufreq_ondemand.c static void od_check_cpu(int cpu, unsigned int load) · line 173

Quoted 7 lines
drivers/cpufreq/cpufreq_ondemand.c +0 -1
@@ -168,7 +168,6 @@ static void od_check_cpu(int cpu, unsigned int load)
                        dbs_info->rate_mult =
                                od_tuners->sampling_down_factor;
                dbs_freq_increase(policy, policy->max);
-               return;
        } else {
                /* Calculate the next frequency proportional to load */
                unsigned int freq_next;
Acked-by Viresh Kumar <[email protected]>
Applied
#2 lore raw
Quoted 11 lines · Viresh Kumar
Quoted 10 lines · Stratos Karafotis

After commit dfa5bb622555d9da0df21b50f46ebdeef390041b "cpufreq: ondemand: Change the calculation of target frequency", this return statement is no longer needed.

Reported-by Henrik Nilsson <[email protected]>
Signed-off-by Stratos Karafotis <[email protected]>
---
 drivers/cpufreq/cpufreq_ondemand.c | 1 -
 1 file changed, 1 deletion(-)
Quoted 14 lines

drivers/cpufreq/cpufreq_ondemand.c static void od_check_cpu(int cpu, unsigned int load) · line 173

Quoted 12 lines
drivers/cpufreq/cpufreq_ondemand.c +0 -1
index 32f26f6..18d4091 100644
@@ -168,7 +168,6 @@ static void od_check_cpu(int cpu, unsigned int load)
                        dbs_info->rate_mult =
                                od_tuners->sampling_down_factor;
                dbs_freq_increase(policy, policy->max);
-               return;
        } else {
                /* Calculate the next frequency proportional to load */
                unsigned int freq_next;
Acked-by Viresh Kumar <[email protected]>

Queued up for 3.13, thanks!

Signature · 2 lines
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
author
#3 lore raw
Quoted 27 lines · Rafael J. Wysocki
Quoted 11 lines · Viresh Kumar
Quoted 10 lines · Stratos Karafotis

After commit dfa5bb622555d9da0df21b50f46ebdeef390041b "cpufreq: ondemand: Change the calculation of target frequency", this return statement is no longer needed.

Reported-by Henrik Nilsson <[email protected]>
Signed-off-by Stratos Karafotis <[email protected]>
---
  drivers/cpufreq/cpufreq_ondemand.c | 1 -
  1 file changed, 1 deletion(-)
Quoted 14 lines

drivers/cpufreq/cpufreq_ondemand.c static void od_check_cpu(int cpu, unsigned int load) · line 173

Quoted 12 lines
drivers/cpufreq/cpufreq_ondemand.c +0 -1
index 32f26f6..18d4091 100644
@@ -168,7 +168,6 @@ static void od_check_cpu(int cpu, unsigned int load)
                         dbs_info->rate_mult =
                                 od_tuners->sampling_down_factor;
                 dbs_freq_increase(policy, policy->max);
-               return;
         } else {
                 /* Calculate the next frequency proportional to load */
                 unsigned int freq_next;
Acked-by Viresh Kumar <[email protected]>
Quoted 2 lines

Queued up for 3.13, thanks!

Thank you both for your immediate response!

Stratos