Skip to contentSkip to conversation

nfsd:add '\n' when read file supported_krb5_enctypes

PATCH In review Weng Meiling 2 participants 5 messages Nov 8, 2013 – Nov 15, 2013 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#1 lore raw

PATCH 1/1 nfsd:add '\n' when read file supported_krb5_enctypes

In reply to a message not in the archive

From: Weng Meiling <[email protected]>

---
 fs/nfsd/nfsctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfsd/nfsctl.c +1 -1
index 7f55517..31db42c 100644
@@ -188,7 +188,7 @@ static const struct file_operations export_features_operations = {
 #if defined(CONFIG_SUNRPC_GSS) || defined(CONFIG_SUNRPC_GSS_MODULE)
 static int supported_enctypes_show(struct seq_file *m, void *v)
 {
-	seq_printf(m, KRB5_SUPPORTED_ENCTYPES);
+	seq_printf(m, "%s\n", KRB5_SUPPORTED_ENCTYPES);
 	return 0;
 }
 
Signature · 1 line
1.8.3.1
#2 lore raw
Quoted 2 lines · Weng Meiling

From: Weng Meiling <[email protected]>

I agree completely that a \n at the end would make more sense.

Have you tested that this nfs-utils is OK with this change?

I suspect that the only code that reads this file anywhere is

nfs-utils/utils/gssd/svcgssd_krb5.c:parse_enctypes()

And on a quick skim of that function.... I *think* it should be fine. But I'd be happier if you could confirm that you've tested it.

--b.

Quoted 25 lines
---
 fs/nfsd/nfsctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfsd/nfsctl.c +1 -1
index 7f55517..31db42c 100644
@@ -188,7 +188,7 @@ static const struct file_operations export_features_operations = {
 #if defined(CONFIG_SUNRPC_GSS) || defined(CONFIG_SUNRPC_GSS_MODULE)
 static int supported_enctypes_show(struct seq_file *m, void *v)
 {
-	seq_printf(m, KRB5_SUPPORTED_ENCTYPES);
+	seq_printf(m, "%s\n", KRB5_SUPPORTED_ENCTYPES);
 	return 0;
 }
 
Signature · 1 line
1.8.3.1
#3 lore raw
Quoted 8 lines · J. Bruce Fields
Quoted 2 lines · Weng Meiling

From: Weng Meiling <[email protected]>

I agree completely that a \n at the end would make more sense.

Have you tested that this nfs-utils is OK with this change?

Quoted 9 lines

I suspect that the only code that reads this file anywhere is

nfs-utils/utils/gssd/svcgssd_krb5.c:parse_enctypes()

And on a quick skim of that function.... I *think* it should be fine. But I'd be happier if you could confirm that you've tested it.

--b.

After this change, starting the nfs server, other host can use the server's shared files normally :-).

Thanks!
Weng Meilling

Quoted 27 lines
Quoted 25 lines
---
 fs/nfsd/nfsctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfsd/nfsctl.c +1 -1
index 7f55517..31db42c 100644
@@ -188,7 +188,7 @@ static const struct file_operations export_features_operations = {
 #if defined(CONFIG_SUNRPC_GSS) || defined(CONFIG_SUNRPC_GSS_MODULE)
 static int supported_enctypes_show(struct seq_file *m, void *v)
 {
-	seq_printf(m, KRB5_SUPPORTED_ENCTYPES);
+	seq_printf(m, "%s\n", KRB5_SUPPORTED_ENCTYPES);
 	return 0;
 }
 
Signature · 1 line
1.8.3.1
#4 lore raw
Quoted 13 lines · Weng Meiling
Quoted 12 lines · J. Bruce Fields
Quoted 2 lines · Weng Meiling

From: Weng Meiling <[email protected]>

I agree completely that a \n at the end would make more sense.

Have you tested that this nfs-utils is OK with this change?

I suspect that the only code that reads this file anywhere is

nfs-utils/utils/gssd/svcgssd_krb5.c:parse_enctypes()

Quoted 7 lines
Quoted 5 lines

And on a quick skim of that function.... I *think* it should be fine. But I'd be happier if you could confirm that you've tested it.

--b.

After this change, starting the nfs server, other host can use the server's shared files normally :-).

I don't see how that tests parse_enctypes().

--b.

Quoted 32 lines

Thanks!
Weng Meilling

Quoted 27 lines
Quoted 25 lines
---
 fs/nfsd/nfsctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfsd/nfsctl.c +1 -1
index 7f55517..31db42c 100644
@@ -188,7 +188,7 @@ static const struct file_operations export_features_operations = {
 #if defined(CONFIG_SUNRPC_GSS) || defined(CONFIG_SUNRPC_GSS_MODULE)
 static int supported_enctypes_show(struct seq_file *m, void *v)
 {
-	seq_printf(m, KRB5_SUPPORTED_ENCTYPES);
+	seq_printf(m, "%s\n", KRB5_SUPPORTED_ENCTYPES);
 	return 0;
 }
 
Signature · 1 line
1.8.3.1
#5 lore raw
Quoted 17 lines · J. Bruce Fields
Quoted 16 lines · Weng Meiling
Quoted 15 lines · J. Bruce Fields
Quoted 2 lines · Weng Meiling

From: Weng Meiling <[email protected]>

I agree completely that a \n at the end would make more sense.

Have you tested that this nfs-utils is OK with this change?

I suspect that the only code that reads this file anywhere is

nfs-utils/utils/gssd/svcgssd_krb5.c:parse_enctypes()

And on a quick skim of that function.... I *think* it should be fine. But I'd be happier if you could confirm that you've tested it.

Quoted 9 lines
Quoted 4 lines
Quoted 2 lines

--b.

After this change, starting the nfs server, other host can use the server's shared files normally :-).

I don't see how that tests parse_enctypes().

--b.

yes,this did not test parse_enctypes() specially, I just try to use nfs with this change, I'll test it later.

Thanks!
Weng Meiling

Quoted 35 lines
Quoted 32 lines

Thanks!
Weng Meilling

Quoted 27 lines
Quoted 25 lines
---
 fs/nfsd/nfsctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfsd/nfsctl.c +1 -1
index 7f55517..31db42c 100644
@@ -188,7 +188,7 @@ static const struct file_operations export_features_operations = {
 #if defined(CONFIG_SUNRPC_GSS) || defined(CONFIG_SUNRPC_GSS_MODULE)
 static int supported_enctypes_show(struct seq_file *m, void *v)
 {
-	seq_printf(m, KRB5_SUPPORTED_ENCTYPES);
+	seq_printf(m, "%s\n", KRB5_SUPPORTED_ENCTYPES);
 	return 0;
 }
 
Signature · 1 line
1.8.3.1

.