Skip to contentSkip to conversation

svcrpc: remove the unnecessary evaluation

PATCH In review Weng Meiling 2 participants 2 messages Nov 8, 2013 – Nov 13, 2013 1 message not in the archive

Subsystems (4)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 svcrpc: remove the unnecessary evaluation

From: Weng Meiling <[email protected]>

---
 net/sunrpc/svc.c | 2 --
 1 file changed, 2 deletions(-)
net/sunrpc/svc.c +0 -2
index b974571..e7fbe36 100644
@@ -1104,8 +1104,6 @@ svc_process_common(struct svc_rqst *rqstp, struct kvec *argv, struct kvec *resv)
 	rqstp->rq_vers = vers = svc_getnl(argv);	/* version number */
 	rqstp->rq_proc = proc = svc_getnl(argv);	/* procedure number */
 
-	progp = serv->sv_program;
-
 	for (progp = serv->sv_program; progp; progp = progp->pg_next)
 		if (prog == progp->pg_prog)
 			break;
Signature · 9 lines
1.8.3.1




--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#2 lore raw
Quoted 2 lines · Weng Meiling

From: Weng Meiling <[email protected]>

Huh. Looks like that was introduced with "[PATCH] knfsd: make sure svc_process call the correct pg_authenticate for multi-service port" in 2005. OK! Applied.

--b.

Quoted 25 lines
---
 net/sunrpc/svc.c | 2 --
 1 file changed, 2 deletions(-)
net/sunrpc/svc.c +0 -2
index b974571..e7fbe36 100644
@@ -1104,8 +1104,6 @@ svc_process_common(struct svc_rqst *rqstp, struct kvec *argv, struct kvec *resv)
 	rqstp->rq_vers = vers = svc_getnl(argv);	/* version number */
 	rqstp->rq_proc = proc = svc_getnl(argv);	/* procedure number */
 
-	progp = serv->sv_program;
-
 	for (progp = serv->sv_program; progp; progp = progp->pg_next)
 		if (prog == progp->pg_prog)
 			break;
Signature · 1 line
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html