Skip to contentSkip to conversation

make oldnoconfig fix?

DISCUSSION David Cohen 4 participants 9 messages Nov 11, 2013 – Dec 23, 2013 Kbuild

lore
Share & tools
lore
#0 lore raw

Hi,

Is there a plan to fix 'make oldnoconfig' option?
I currently have need to it :)
I've tracked a thread fixing 'make olddefconfig' where 'oldnoconfig' option is reported as a known bug, right?

Br, David Cohen

#1 lore raw

David, All,

On 2013-11-11 10:11 -0800, David Cohen spake thusly:

Quoted 4 lines

Is there a plan to fix 'make oldnoconfig' option?
I currently have need to it :)
I've tracked a thread fixing 'make olddefconfig' where 'oldnoconfig' option is reported as a known bug, right?

Sorry, I don't understand what your problem is.

Care to explain in details what problem you have:
- what you start with
- what you do
- what you get
- what you expected

So we can try to reproduce the issue and investigate what is wrong.

Since you mention an existing thread, please add a pointer (URL) to this thread in the archives (Use: http://marc.info/?l=linux-kbuild ).

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#7 lore raw
In reply to David Cohen

Hi David,

Quoted 2 lines · David Cohen

Is there a plan to fix 'make oldnoconfig' option?
I currently have need to it :)

I actually rely on this, but didn't know there was this option, this is what I've been doing since a long time:

% echo '' | make oldconfig

But it's very hacky and I see tons of errors reported, but it does what I expect.

Cheers.

Signature · 1 line
Felipe Contreras
#8 lore raw

Hi Felipe,

Quoted 8 lines · Felipe Contreras

Hi David,

Quoted 2 lines · David Cohen

Is there a plan to fix 'make oldnoconfig' option?
I currently have need to it :)

Quoted 7 lines

I actually rely on this, but didn't know there was this option, this is what I've been doing since a long time:

% echo '' | make oldconfig

But it's very hacky and I see tons of errors reported, but it does what I expect.

Thanks for the tip. I'll give it a try.

Br, David

#2 lore raw
In reply to Yann E. MORIN
Quoted 1 line · Yann E. MORIN

David, All,

Hi Yann,

Quoted 8 lines

On 2013-11-11 10:11 -0800, David Cohen spake thusly:

Quoted 4 lines

Is there a plan to fix 'make oldnoconfig' option?
I currently have need to it :)
I've tracked a thread fixing 'make olddefconfig' where 'oldnoconfig' option is reported as a known bug, right?

Sorry, I don't understand what your problem is.

Maybe I assumed it was more 'known' then it actually is :)

Quoted 6 lines

Care to explain in details what problem you have:
- what you start with
- what you do
- what you get
- what you expected

The bug with 'oldnoconfig' is: 'make oldnoconfig' is just an alias to 'olddefconfig'. Any non-existent config is defined with its default value instead of 'N'.

I work with embedded platforms. I need to maintain a set of defconfigs for different products (customers some times want tailored configs, so creating a generic one isn't an option always).

In order to have full control of the .config generated out of defconfigs, I don't allow any CONFIG_ to be selected implicitly. So everytime a Kconfig is changed in our internal tree, we need to update all defconfigs either with CONFIG_... = [y|n] or # CONFIG_... is not set

If I managed to get 'make oldnoconfig' working, I could not care about # CONFIG_... is not set and internal and changes to defconfigs would be easily to understand and review.

Quoted 2 lines

So we can try to reproduce the issue and investigate what is wrong.

All we need to know is explained in this commit:

commit fb16d8912db5268f29706010ecafff74b971c58d

Author: Adam Lee <[email protected]>
Date:   Sat Sep 1 01:05:17 2012 +0800

kconfig: replace 'oldnoconfig' with 'olddefconfig', and keep the
old name as an alias

As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, 'oldnoconfig' doesn't set new symbols to 'n', but instead sets it to their default values.

So, this patch replaces 'oldnoconfig' with 'olddefconfig', stop making people confused, and keep the old name 'oldnoconfig' as an alias, because people already are dependent on its behavior with the counter-intuitive name.

Quoted 3 lines

Since you mention an existing thread, please add a pointer (URL) to this thread in the archives (Use: http://marc.info/?l=linux-kbuild ).

This is the thread I was talking about: http://comments.gmane.org/gmane.linux.kbuild.devel/8560

Master Yoda promised to fix it when the problem gets bigger :)

Br, David

#3 lore raw
Quoted 65 lines · David Cohen
Quoted 1 line · Yann E. MORIN

David, All,

Hi Yann,

Quoted 8 lines

On 2013-11-11 10:11 -0800, David Cohen spake thusly:

Quoted 4 lines

Is there a plan to fix 'make oldnoconfig' option?
I currently have need to it :)
I've tracked a thread fixing 'make olddefconfig' where 'oldnoconfig' option is reported as a known bug, right?

Sorry, I don't understand what your problem is.

Maybe I assumed it was more 'known' then it actually is :)

Quoted 6 lines

Care to explain in details what problem you have:
- what you start with
- what you do
- what you get
- what you expected

The bug with 'oldnoconfig' is: 'make oldnoconfig' is just an alias to 'olddefconfig'. Any non-existent config is defined with its default value instead of 'N'.

I work with embedded platforms. I need to maintain a set of defconfigs for different products (customers some times want tailored configs, so creating a generic one isn't an option always).

In order to have full control of the .config generated out of defconfigs, I don't allow any CONFIG_ to be selected implicitly. So everytime a Kconfig is changed in our internal tree, we need to update all defconfigs either with CONFIG_... = [y|n] or # CONFIG_... is not set

If I managed to get 'make oldnoconfig' working, I could not care about # CONFIG_... is not set and internal and changes to defconfigs would be easily to understand and review.

Quoted 2 lines

So we can try to reproduce the issue and investigate what is wrong.

All we need to know is explained in this commit:

commit fb16d8912db5268f29706010ecafff74b971c58d

Author: Adam Lee <[email protected]>
Date:   Sat Sep 1 01:05:17 2012 +0800

kconfig: replace 'oldnoconfig' with 'olddefconfig', and keep the old
name as an alias

As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, 'oldnoconfig' doesn't set new symbols to 'n', but instead sets it to their default values.

So, this patch replaces 'oldnoconfig' with 'olddefconfig', stop making people confused, and keep the old name 'oldnoconfig' as an alias, because people already are dependent on its behavior with the counter-intuitive name.

Quoted 1 line
Quoted 7 lines
Quoted 2 lines

Since you mention an existing thread, please add a pointer (URL) to this thread in the archives (Use: http://marc.info/?l=linux-kbuild ).

This is the thread I was talking about:
http://comments.gmane.org/gmane.linux.kbuild.devel/8560

Master Yoda promised to fix it when the problem gets bigger :)

Any comments here? :)

Br, David Cohen

#4 lore raw
In reply to David Cohen
Quoted 23 lines · David Cohen
Quoted 1 line · Yann E. MORIN

David, All,

Hi Yann,

Quoted 8 lines

On 2013-11-11 10:11 -0800, David Cohen spake thusly:

Quoted 4 lines

Is there a plan to fix 'make oldnoconfig' option?
I currently have need to it :)
I've tracked a thread fixing 'make olddefconfig' where 'oldnoconfig' option is reported as a known bug, right?

Sorry, I don't understand what your problem is.

Maybe I assumed it was more 'known' then it actually is :)

Quoted 6 lines

Care to explain in details what problem you have:
- what you start with
- what you do
- what you get
- what you expected

Quoted 7 lines

The bug with 'oldnoconfig' is: 'make oldnoconfig' is just an alias to 'olddefconfig'. Any non-existent config is defined with its default value instead of 'N'.

I work with embedded platforms. I need to maintain a set of defconfigs for different products (customers some times want tailored configs, so creating a generic one isn't an option always).

make allnoconfig KCONFIG_ALLCONFIG=oldconfigfile

I use this trick in http://landley.net/aboriginal/FAQ.html#dev_miniconfig

And yes, I submitted it upstream a couple times last decade, with documentation and everything:

https://lwn.net/Articles/160497/
https://lwn.net/Articles/161086/
http://lkml.indiana.edu/hypermail/linux/kernel/0607.0/1805.html

Rob

#5 lore raw
Quoted 28 lines · Rob Landley
Quoted 27 lines · David Cohen
Quoted 1 line · Yann E. MORIN

David, All,

Hi Yann,

Quoted 8 lines

On 2013-11-11 10:11 -0800, David Cohen spake thusly:

Quoted 4 lines

Is there a plan to fix 'make oldnoconfig' option?
I currently have need to it :)
I've tracked a thread fixing 'make olddefconfig' where 'oldnoconfig' option is reported as a known bug, right?

Sorry, I don't understand what your problem is.

Maybe I assumed it was more 'known' then it actually is :)

Quoted 6 lines

Care to explain in details what problem you have:
- what you start with
- what you do
- what you get
- what you expected

The bug with 'oldnoconfig' is: 'make oldnoconfig' is just an alias to 'olddefconfig'. Any non-existent config is defined with its default value instead of 'N'.

Quoted 5 lines
Quoted 3 lines

I work with embedded platforms. I need to maintain a set of defconfigs for different products (customers some times want tailored configs, so creating a generic one isn't an option always).

make allnoconfig KCONFIG_ALLCONFIG=oldconfigfile

I'll give it a try. Thanks!

Quoted 5 lines

I use this trick in http://landley.net/aboriginal/FAQ.html#dev_miniconfig

And yes, I submitted it upstream a couple times last decade, with documentation and everything:

You could send it again.
But maybe oldnoconfig would be a better name WRT current standard.

Br, David

Quoted 6 lines

https://lwn.net/Articles/160497/
https://lwn.net/Articles/161086/
http://lkml.indiana.edu/hypermail/linux/kernel/0607.0/1805.html

Rob

#6 lore raw
Quoted 38 lines · David Cohen
Quoted 28 lines · Rob Landley
Quoted 27 lines · David Cohen
Quoted 1 line · Yann E. MORIN

David, All,

Hi Yann,

Quoted 8 lines

On 2013-11-11 10:11 -0800, David Cohen spake thusly:

Quoted 4 lines

Is there a plan to fix 'make oldnoconfig' option?
I currently have need to it :)
I've tracked a thread fixing 'make olddefconfig' where 'oldnoconfig' option is reported as a known bug, right?

Sorry, I don't understand what your problem is.

Maybe I assumed it was more 'known' then it actually is :)

Quoted 6 lines

Care to explain in details what problem you have:
- what you start with
- what you do
- what you get
- what you expected

The bug with 'oldnoconfig' is: 'make oldnoconfig' is just an alias to 'olddefconfig'. Any non-existent config is defined with its default value instead of 'N'.

Quoted 5 lines
Quoted 3 lines

I work with embedded platforms. I need to maintain a set of defconfigs for different products (customers some times want tailored configs, so creating a generic one isn't an option always).

make allnoconfig KCONFIG_ALLCONFIG=oldconfigfile

I'll give it a try. Thanks!

Quoted 1 line
Quoted 6 lines
Quoted 4 lines

I use this trick in http://landley.net/aboriginal/FAQ.html#dev_miniconfig

And yes, I submitted it upstream a couple times last decade, with documentation and everything:

You could send it again.

I linked you to three times I sent it:

Quoted 3 lines
Quoted 3 lines
   https://lwn.net/Articles/160497/
   https://lwn.net/Articles/161086/
   http://lkml.indiana.edu/hypermail/linux/kernel/0607.0/1805.html

Plus I made sure it worked in busybox and uClibc:

http://lists.uclibc.org/pipermail/uclibc/2007-March/038469.html

Other people picked up on it:

http://www.brain-dump.org/blog/show-entry.php?id=109
http://techoverflow.net/blog/2013/07/09/user-mode-linux-for-beginners-part-1-setup-and-first-vm/

Somebody even added it to the Documentation directory a few years back (while I wasn't looking):

https://www.kernel.org/doc/Documentation/kbuild/kconfig.txt

The problem was the kbuild maintainer at the time categorically rejected the idea in a very long thread. (The replies to that "take 2" lasted two weeks.) He was the maintainer, his no was final, so I went off and did other things.

Quoted 3 lines

But maybe oldnoconfig would be a better name WRT current standard.

Br, David

As you can see from the rapid response time, I'm a touch overwhelmed of late.

I've been offering miniconfig stuff to people for years, but the upstream guys had zero interest when I pinged 'em and still don't, last I checked. When Linus yanked the giant forest of arm defconfigs he decided to have kconfig snippets generate different defconfigs instead of miniconfig (which turns out not to be particularly maintainable, but oh well).

If somebody else wanted to take the basic concept and push it upstream, I'd happily review and ack, but I haven't got it in me to replicate the 7 years the initramfs guy spent convincing upstream to Do It My Way. I scratch my own itch, offer it to other people, they say no, and after about the third attempt I go do other things. My todo list runneth over, no shortage of other things...

Rob