Skip to contentSkip to conversation

Audit Cross Compile Support

PATCH New AKASHI Takahiro 2 participants 3 messages Nov 12, 2013 – Nov 15, 2013 Library code

lore
Share & tools
lore

AKASHI Takahiro

author
#0 lore raw

Hello Clayton,

I picked up your patches and tried to cross-build the package for AArch64. In the following code of lib/gen_tables.py,

	parser.add_argument('--i2s', dest='gen_i2s', action='',

should be

	parser.add_argument('--i2s', dest='gen_i2s', action='store_true',

Right?

-Takahiro AKASHI

#1 lore raw

AKASHI Takahiro <[email protected]> wrote on 11/12/2013 04:15:36 AM:

Quoted 11 lines

From: AKASHI Takahiro <[email protected]>
To: [email protected]
Cc: "[email protected]" <[email protected]>
Date: 11/12/2013 04:17 AM
Subject: Audit Cross Compile Support

Hello Clayton,

I picked up your patches and tried to cross-build the package for AArch64. In the following code of lib/gen_tables.py,

Quoted 7 lines
   parser.add_argument('--i2s', dest='gen_i2s', action='',

should be

   parser.add_argument('--i2s', dest='gen_i2s', action='store_true',

Right?

Yes it should be. Thanks for catching that. Would you like updated patches sent out?

Thanks,
Clayton

Clayton Shotwell
Software Engineer
[email protected]
www.rockwellcollins.com

author
#2 lore raw

PATCH 1/1 Fix gen_tables.py in parsing arguments

Hi Clayton

Patch only for my changes, nothing fancy.

-Takahiro AKASHI

action in add_argument() should not be NULL('').

Signed-off-by AKASHI Takahiro <[email protected]>
---
 lib/gen_tables.py |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
lib/gen_tables.py +6 -6
index 88039b1..433dd8b 100644
@@ -388,19 +388,19 @@ def main():
         
         # Setup the argument parser and parse the arguments given
         parser = argparse.ArgumentParser(description='Generate tables header files.')
-        parser.add_argument('--i2s', dest='gen_i2s', action='',
+        parser.add_argument('--i2s', dest='gen_i2s', action='store_true',
                         help='Generate i2s tables')
-        parser.add_argument('--i2s-transtab', dest='gen_i2s_transtab', action='',
+        parser.add_argument('--i2s-transtab', dest='gen_i2s_transtab', action='store_true',
                         help='Generate transtab tables')
-        parser.add_argument('--s2i', dest='gen_s2i', action='',
+        parser.add_argument('--s2i', dest='gen_s2i', action='store_true',
                         help='Generate s2i tables')
         # Make sure uppercase and lowercase are mutually exclusive
         group = parser.add_mutually_exclusive_group()
-        group.add_argument('--uppercase', dest='uppercase', action='',
+        group.add_argument('--uppercase', dest='uppercase', action='store_true',
                         help='All characters are uppercase')
-        group.add_argument('--lowercase', dest='lowercase', action='',
+        group.add_argument('--lowercase', dest='lowercase', action='store_true',
                         help='All characters are lowercase')
-        parser.add_argument('--duplicate-ints', dest='allow_duplicate_ints', action='',
+        parser.add_argument('--duplicate-ints', dest='allow_duplicate_ints', action='store_true',
                         help='Allow duplicate integers')
         parser.add_argument('prefix', help='The prefix of the output file to use')
         parser.add_argument('source', type=argparse.FileType('r'),
Signature · 1 line
1.7.9.5