xen: simplify balloon_first_page() with list_first_entry_or_null()
PATCH 1/1 xen: simplify balloon_first_page() with list_first_entry_or_null()
From: Jie Liu <[email protected]>
Simplify the code logic of balloon_first_page() by replacing the combination of list_empty() and list_first_entry() with list_first_entry_or_null(). As a net win, we can change this routine to inline as now it's one line.
--- drivers/xen/balloon.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/xen/balloon.c +3 -4
@@ -157,11 +157,10 @@ static struct page *balloon_retrieve(bool prefer_highmem)return page; } -static struct page *balloon_first_page (void ) +static inline struct page *balloon_first_page (void ) { -if (list_empty (&ballooned_pages)) -return NULL ; - return list_entry(ballooned_pages.next, struct page, lru); +return list_first_entry_or_null (&ballooned_pages, + struct page, lru); }static struct page *balloon_next_page (struct page *page)
Signature · 1 line
1.7.9.5
Quoted 20 lines · Jeff Liu
From: Jie Liu <[email protected]>
Simplify the code logic of
balloon_first_page()by replacing the combination oflist_empty()andlist_first_entry()withlist_first_entry_or_null(). As a net win, we can change this routine to inline as now it's one line.Signed-off-by Jie Liu <[email protected]>--- drivers/xen/balloon.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)drivers/xen/balloon.c +0
-0@@ -157,11 +157,10 @@ static struct page *balloon_retrieve(bool prefer_highmem)return page; }
drivers/xen/balloon.c static struct page *balloon_retrieve(bool prefer_highmem) · line 164
Quoted 10 lines
drivers/xen/balloon.c +3
-4-static struct page *balloon_first_page (void ) +static inline struct page *balloon_first_page (void ) { -if (list_empty (&ballooned_pages)) -return NULL ; - return list_entry(ballooned_pages.next, struct page, lru); +return list_first_entry_or_null (&ballooned_pages, + struct page, lru); }
There's only one user of balloon_first_page(), can you remove balloon_first_page() and just use list_first_entry_or_null()?
David
Quoted 22 lines · David Vrabel
Quoted 21 lines · Jeff Liu
From: Jie Liu <[email protected]>
Simplify the code logic of
balloon_first_page()by replacing the combination oflist_empty()andlist_first_entry()withlist_first_entry_or_null(). As a net win, we can change this routine to inline as now it's one line.Signed-off-by Jie Liu <[email protected]>--- drivers/xen/balloon.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)drivers/xen/balloon.c +0
-0@@ -157,11 +157,10 @@ static struct page *balloon_retrieve(bool prefer_highmem)return page; }
Quoted 12 lines
drivers/xen/balloon.c static struct page *balloon_retrieve(bool prefer_highmem) · line 164
Quoted 9 lines
drivers/xen/balloon.c +3
-4-static struct page *balloon_first_page (void ) +static inline struct page *balloon_first_page (void ) { -if (list_empty (&ballooned_pages)) -return NULL ; - return list_entry(ballooned_pages.next, struct page, lru); +return list_first_entry_or_null (&ballooned_pages, + struct page, lru); }There's only one user of
balloon_first_page(), can you removeballoon_first_page()and just uselist_first_entry_or_null()?
Sure, will post the revised version a little while.
Thanks,
-Jeff