Skip to contentSkip to conversation

Compile error in i2c-bcm-kona.c

DISCUSSION Guenter Roeck 2 participants 2 messages Nov 25, 2013 I2C subsystem host drivers

lore
Share & tools
lore
#0 lore raw

Upstream HEAD, arm allmodconfig:

drivers/i2c/busses/i2c-bcm-kona.c:894:1: error: '__mod_of_device_table' aliased to undefined symbol 'kona_i2c_of_match' make[3]: *** [drivers/i2c/busses/i2c-bcm-kona.o] Error 1
make[2]: *** [drivers/i2c/busses] Error 2
make[1]: *** [drivers/i2c] Error 2
make[1]: *** Waiting for unfinished jobs....

Source:

static const struct of_device_id bcm_kona_i2c_of_match[] = {
        {.compatible = "brcm,kona-i2c",},
        {},
};

MODULE_DEVICE_TABLE(of, kona_i2c_of_match);

Makes me wonder how this was tested :-(.

Guenter

#1 lore raw
Quoted 15 lines · Guenter Roeck

Upstream HEAD, arm allmodconfig:

drivers/i2c/busses/i2c-bcm-kona.c:894:1: error: '__mod_of_device_table' aliased to undefined symbol 'kona_i2c_of_match'
make[3]: *** [drivers/i2c/busses/i2c-bcm-kona.o] Error 1 make[2]: *** [drivers/i2c/busses] Error 2
make[1]: *** [drivers/i2c] Error 2
make[1]: *** Waiting for unfinished jobs....

Source:

static const struct of_device_id bcm_kona_i2c_of_match[] = {
        {.compatible = "brcm,kona-i2c",},
        {},
};
Quoted 5 lines

MODULE_DEVICE_TABLE(of, kona_i2c_of_match);

Makes me wonder how this was tested :-(.

Guenter

The statically linked driver was tested extensively but I forgot to test it as a module.

Please accept my sincerest apologies for this oversight.

I will prepare, test, and post a fix shortly.

-Tim